compiletest: Make ./x test --test-args ... work again #146601
Merged
+6 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It accidentally broke with a48c8e3. The intention of that commit was to keep existing behavior if `--exact` is not used, but it had a bug. This commit fixes that bug.
| Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot added A-compiletest 
| See #146501 (comment). (My bad!) |
| @bors r+ Might be a good idea to try to figure out some unit tests for this code? |
bors added S-waiting-on-bors
One good CI test would be to make sure that runs one test. (That would have caught this bug.) |
bors added a commit that referenced this pull request Sep 16, 2025
Rollup of 9 pull requests Successful merges: - #145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - #145960 (Split `FnCtxt::report_args_error` into subfunctions) - #146402 (interpret: fix overlapping aggregate initialization) - #146466 (llvm-wrapper: other cleanup) - #146574 (compiletest: Enable new-output-capture by default) - #146599 (replace some `#[const_trait]` with `const trait`) - #146601 (compiletest: Make `./x test --test-args ...` work again) - #146608 (improve internal bootstrap docs) - #146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 16, 2025
Rollup of 9 pull requests Successful merges: - #145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - #145960 (Split `FnCtxt::report_args_error` into subfunctions) - #146402 (interpret: fix overlapping aggregate initialization) - #146466 (llvm-wrapper: other cleanup) - #146574 (compiletest: Enable new-output-capture by default) - #146599 (replace some `#[const_trait]` with `const trait`) - #146601 (compiletest: Make `./x test --test-args ...` work again) - #146608 (improve internal bootstrap docs) - #146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 17, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - rust-lang/rust#145960 (Split `FnCtxt::report_args_error` into subfunctions) - rust-lang/rust#146402 (interpret: fix overlapping aggregate initialization) - rust-lang/rust#146466 (llvm-wrapper: other cleanup) - rust-lang/rust#146574 (compiletest: Enable new-output-capture by default) - rust-lang/rust#146599 (replace some `#[const_trait]` with `const trait`) - rust-lang/rust#146601 (compiletest: Make `./x test --test-args ...` work again) - rust-lang/rust#146608 (improve internal bootstrap docs) - rust-lang/rust#146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 21, 2025
…ulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See rust-lang#146601 (comment) r? `@Mark-Simulacrum`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 21, 2025
…ulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See rust-lang#146601 (comment) r? ``@Mark-Simulacrum``
rust-timer added a commit that referenced this pull request Sep 21, 2025
Rollup merge of #146606 - Enselic:test-test-args, r=Mark-Simulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See #146601 (comment) r? ``@Mark-Simulacrum``
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
…ulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See rust-lang#146601 (comment) r? ``@Mark-Simulacrum``
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - rust-lang#145960 (Split `FnCtxt::report_args_error` into subfunctions) - rust-lang#146402 (interpret: fix overlapping aggregate initialization) - rust-lang#146466 (llvm-wrapper: other cleanup) - rust-lang#146574 (compiletest: Enable new-output-capture by default) - rust-lang#146599 (replace some `#[const_trait]` with `const trait`) - rust-lang#146601 (compiletest: Make `./x test --test-args ...` work again) - rust-lang#146608 (improve internal bootstrap docs) - rust-lang#146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It accidentally broke with #146501. The intention of that PR was to keep existing behavior if
--exactis not used, but it had a bug. This PR fixes that bug.