Add span for struct tail recursion limit error #146597
Conversation
rustbot added S-waiting-on-review 
modhanami force-pushed the add-struct-tail-recursion-limit-span branch from 38571c8 to b3e072a Compare | This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
| r? compiler (reduced bandwidth during weekday) |
This comment has been minimized.
This comment has been minimized.
modhanami force-pushed the add-struct-tail-recursion-limit-span branch from b3e072a to f2998f3 Compare This comment has been minimized.
This comment has been minimized.
Because I asked for this without fully explaining my reasoning. If most sites have obligation causes, then passing a reference to them seemed less annoying than just the span, and could allow emitting the rest of the obligation cause code to give more context where available |
| Since this PR is only using span, I should be applying @compiler-errors's suggestion, right? |
| Works for me if that gets it unblocked, but not my preference So: yea do that and we'll land it and I'll figure out whether to use obligation causes on my own time |
| don't let this be blocked on me in that case r? oli-obk |
|
|
modhanami force-pushed the add-struct-tail-recursion-limit-span branch from f2998f3 to 5bf8d13 Compare 
| } | ||
| | ||
| //~? ERROR reached the recursion limit finding the struct tail for `K` | ||
| //~? ERROR reached the recursion limit finding the struct tail for `Bottom` |
There was a problem hiding this comment.
why did you move from //~? to pointing them at the first line in the file, even though nothing in the output changed? Is the json different and thus suggesting this to be done?
There was a problem hiding this comment.
Yes, I was suggested to move //~? to point at the first line in many files. I'm not sure why or whether it is expected.
From rust-log-analyzer
oli-obk added S-waiting-on-author 
modhanami force-pushed the add-struct-tail-recursion-limit-span branch from 5bf8d13 to 6912631 Compare rustbot added S-waiting-on-review | @bors r+ rollup |
bors added S-waiting-on-bors 
Rollup of 6 pull requests Successful merges: - #146434 (c-variadic: allow c-variadic inherent and trait methods) - #146487 (Improve `core::num` coverage) - #146597 (Add span for struct tail recursion limit error) - #146622 (Add regression test for issue #91831) - #146717 (Clean up universe evaluation during type test evaluation) - #146723 (Include patch in release notes) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #146597 - modhanami:add-struct-tail-recursion-limit-span, r=oli-obk Add span for struct tail recursion limit error Fixes #135629 Changes 1. Add span to RecursionLimitReached 2. Add ObligationCause parameter to struct_tail_raw 4. Update call sites to pass nearby ObligationCause or create one 5. Update affected .stderr
8 participants
Fixes #135629
Changes