Skip to content

Rehome 26 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#5 of Batch #2] #146490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rehome 26 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#5 of Batch #2] #146490

wants to merge 1 commit into from

Conversation

Oneirical
Copy link
Contributor

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

Inspired by the methodology that Kivooeo was using.

r? @jieyouxu
@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member 

error: aux-build `/checkout/tests/ui/issues/auxiliary/reexported-trait.rs` source not found

@rustbot author
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from 8ae4b39 to 7d6d136 Compare October 1, 2025 03:38
@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2025
jieyouxu
jieyouxu requested changes Oct 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few nits

View changes since this review
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from 7d6d136 to d28c7f4 Compare October 12, 2025 02:12
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2025

⚠️ Warning ⚠️
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from d28c7f4 to 9a73fa6 Compare October 12, 2025 03:01
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from 9a73fa6 to 926599a Compare October 12, 2025 04:33
@Oneirical
Copy link
Contributor Author

@rustbot ready
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants

@Oneirical @rustbot @rust-log-analyzer @jieyouxu