Skip to content

fix path str eq #146194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix path str eq #146194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f19da67
add test
bend-n Sep 4, 2025
1e37c1f
fix
bend-n Sep 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/std/src/path.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2107,7 +2107,7 @@ impl PartialEq for PathBuf {
impl cmp::PartialEq<str> for PathBuf {
#[inline]
fn eq(&self, other: &str) -> bool {
&*self == other
Path::eq(self, other)
}
}

Expand Down
6 changes: 6 additions & 0 deletions library/std/tests/path.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2526,3 +2526,9 @@ fn normalize_lexically() {
check_err(r"\\?\UNC\server\share\a\..\..");
}
}

#[test]
/// See issue#146183
fn compare_path_to_str() {
assert!(&PathBuf::from("x") == "x");
}
Loading