port `sanitize` attribute to the new parsing infrastructure #145670

jdonszelmann · 2025-08-20T16:14:34Z

No description provided.

tests/ui/sanitize-attr/invalid-sanitize.stderr

rustbot · 2025-08-20T16:16:46Z

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-20T16:16:49Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

jdonszelmann · 2025-08-20T19:23:49Z

ah I see. Well I did make it mostly yes/no based but I think it'd be better to modify this version of the parser than the old one

jdonszelmann · 2025-08-20T19:24:40Z

PRs welcome, and feel free to ask me for review. I just thought that much work on the old parser wouldn't necessarily be useful. But if this one needs modifications that's totally fine

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs

bors · 2025-08-22T03:22:32Z

☔ The latest upstream changes (presumably #145728) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

compiler/rustc_passes/src/check_attr.rs

lcnr

some nits and questions, otherwise r=me

View changes since this review

Rollup of 20 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144443 (Make target pointer width in target json an integer) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) Failed merges: - #145670 (port `sanitize` attribute to the new parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

…ols, r=lqd convert strings to symbols in attr diagnostics r? `@lcnr` As you rightfully noticed in rust-lang#145670

Rollup merge of #145762 - jdonszelmann:attrs-strings-to-symbols, r=lqd convert strings to symbols in attr diagnostics r? `@lcnr` As you rightfully noticed in #145670

bors · 2025-08-23T09:32:46Z

☔ The latest upstream changes (presumably #145773) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-08-23T10:26:10Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2025-08-23T10:49:09Z

@bors r=lcnr

bors · 2025-08-23T10:49:11Z

📌 Commit 1c03ae1 has been approved by lcnr

It is now in the queue for this repository.

port `sanitize` attribute to the new parsing infrastructure

Rollup of 14 pull requests Successful merges: - #143898 (opt-dist: rebuild rustc when doing static LLVM builds) - #144452 (std/sys/fd: Relax `READ_LIMIT` on Darwin) - #145234 (match exhaustiveness diagnostics: show a trailing comma on singleton tuple consructors in witness patterns (and clean up a little)) - #145515 (Optimize `char::encode_utf8`) - #145540 (interpret/allocation: get_range on ProvenanceMap) - #145670 (port `sanitize` attribute to the new parsing infrastructure) - #145713 (next-solver: fix `feature(const_trait_impl)` bootstrap) - #145729 (Remove two duplicated crates) - #145744 (miri: also detect aliasing of in-place argument and return place) - #145774 (Remove default opts from config) - #145781 (Remove profile section from Clippy) - #145782 (rustdoc: make attributes render consistently) - #145787 (citool: cleanup `mismatched_lifetime_syntaxes` warnings) - #145791 (Fix ICE when validating transmuting ZST to inhabited enum) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145670 - jdonszelmann:port-sanitize, r=lcnr port `sanitize` attribute to the new parsing infrastructure

jhpratt · 2025-08-24T02:51:22Z

still in queue

@bors r-

convert strings to symbols in attr diagnostics r? `@lcnr` As you rightfully noticed in rust-lang/rust#145670

Rollup of 14 pull requests Successful merges: - rust-lang/rust#143898 (opt-dist: rebuild rustc when doing static LLVM builds) - rust-lang/rust#144452 (std/sys/fd: Relax `READ_LIMIT` on Darwin) - rust-lang/rust#145234 (match exhaustiveness diagnostics: show a trailing comma on singleton tuple consructors in witness patterns (and clean up a little)) - rust-lang/rust#145515 (Optimize `char::encode_utf8`) - rust-lang/rust#145540 (interpret/allocation: get_range on ProvenanceMap) - rust-lang/rust#145670 (port `sanitize` attribute to the new parsing infrastructure) - rust-lang/rust#145713 (next-solver: fix `feature(const_trait_impl)` bootstrap) - rust-lang/rust#145729 (Remove two duplicated crates) - rust-lang/rust#145744 (miri: also detect aliasing of in-place argument and return place) - rust-lang/rust#145774 (Remove default opts from config) - rust-lang/rust#145781 (Remove profile section from Clippy) - rust-lang/rust#145782 (rustdoc: make attributes render consistently) - rust-lang/rust#145787 (citool: cleanup `mismatched_lifetime_syntaxes` warnings) - rust-lang/rust#145791 (Fix ICE when validating transmuting ZST to inhabited enum) r? `@ghost` `@rustbot` modify labels: rollup

convert strings to symbols in attr diagnostics r? `@lcnr` As you rightfully noticed in rust-lang/rust#145670

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2025

jdonszelmann commented Aug 20, 2025

View reviewed changes

tests/ui/sanitize-attr/invalid-sanitize.stderr Show resolved Hide resolved

jdonszelmann marked this pull request as ready for review August 20, 2025 16:16

rustbot assigned lcnr Aug 20, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2025

jdonszelmann mentioned this pull request Aug 20, 2025

Better sanitize attr diagnostic #145182

Closed

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

jdonszelmann force-pushed the port-sanitize branch from a8d9517 to a93c6ad Compare August 21, 2025 08:03

luca3s reviewed Aug 21, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the port-sanitize branch from a93c6ad to 6bd768e Compare August 21, 2025 12:46

This comment has been minimized.

Sign in to view