Skip to content

Remove duplicated tracing span in bootstrap #145453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2025
Merged

Remove duplicated tracing span in bootstrap #145453

merged 1 commit into from
Aug 16, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 15, 2025

trace_cmd is now called also in the stream method, so including it also here was duplicating command spans.

r? @jieyouxu
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 15, 2025
jieyouxu
jieyouxu approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@jieyouxu
Copy link
Member

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Aug 15, 2025

📌 Commit 33218a2 has been approved by jieyouxu

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2025
@jhpratt jhpratt mentioned this pull request Aug 15, 2025
Merged
bors added a commit that referenced this pull request Aug 15, 2025
@bors
Auto merge of #145475 - jhpratt:rollup-jr0wado, r=jhpratt
1ae7c49 
Rollup of 11 pull requests Successful merges: - #143717 (Add `Default` impls for `Pin`ned `Box`, `Rc`, `Arc`) - #144054 (Stabilize as_array_of_cells) - #144907 (fix: Reject async assoc fns of const traits/impls in ast_passes) - #144922 (Implement `#[derive(From)]`) - #144963 (Stabilize `core::iter::chain`) - #145436 (fix(tests/rmake/wasm-unexpected-features): change features from `WASM1` to `MVP`) - #145453 (Remove duplicated tracing span in bootstrap) - #145454 (Fix tracing debug representation of steps without arguments in bootstrap) - #145455 (Do not copy files in `copy_src_dirs` in dry run) - #145462 (Stabilize `const_exposed_provenance` feature) - #145466 (Enable new `[range-diff]` feature in triagebot) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 71adb87 into rust-lang:master Aug 16, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 16, 2025
rust-timer added a commit that referenced this pull request Aug 16, 2025
@rust-timer
Unrolled build for #145453
b930880 
Rollup merge of #145453 - Kobzol:bootstrap-cmd-span, r=jieyouxu Remove duplicated tracing span in bootstrap `trace_cmd` is now called also in the `stream` method, so including it also here was duplicating command spans. r? `@jieyouxu`
@jhpratt
Copy link
Member

jhpratt commented Aug 16, 2025

still in queue; merged in #145475

@bors r-
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2025
@Kobzol Kobzol deleted the bootstrap-cmd-span branch August 16, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

5 participants

@Kobzol @jieyouxu @bors @jhpratt @rustbot