- Notifications
You must be signed in to change notification settings - Fork 13.9k
[TOY] Run MIR opts before coroutine state transform #145330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
08f1ddf
to 0be736b
Compare This comment has been minimized.
This comment has been minimized.
@bors try |
This comment has been minimized.
This comment has been minimized.
[TOY] Run MIR opts before coroutine state transform
@rust-timer queue |
This comment has been minimized.
This comment has been minimized.
@rust-timer build b6ae10a |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (b6ae10a): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.4%, secondary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 468.291s -> 467.628s (-0.14%) |
☔ The latest upstream changes (presumably #145600) made this pull request unmergeable. Please resolve the merge conflicts. |
0be736b
to dea9eb7
Compare This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #145916) made this pull request unmergeable. Please resolve the merge conflicts. |
dea9eb7
to 7f2f7ac
Compare This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts. |
7f2f7ac
to 8563507
Compare This comment has been minimized.
This comment has been minimized.
8563507
to 5c25cff
Compare This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
Footnotes
|
@craterbot run mode=build-and-test crates=https://crater-reports.s3.amazonaws.com/pr-145330/retry-regressed-list.txt |
1 similar comment
@craterbot run mode=build-and-test crates=https://crater-reports.s3.amazonaws.com/pr-145330/retry-regressed-list.txt |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
Footnotes
|
☔ The latest upstream changes (presumably #142771) made this pull request unmergeable. Please resolve the merge conflicts. |
5c25cff
to 2918477
Compare This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #145608) made this pull request unmergeable. Please resolve the merge conflicts. |
2918477
to 5e47c8e
Compare ☔ The latest upstream changes (presumably #145513) made this pull request unmergeable. Please resolve the merge conflicts. |
abfdcc9
to 0af6ba6
Compare The job Click to see the possible cause of the failure (guessed by this bot)
For more information how to resolve CI failures of this job, visit this link. |
r? @ghost