Skip to content

Regression test for bad codegen of #[derive(Clone)] on enums #144961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Regression test for bad codegen of #[derive(Clone)] on enums #144961

wants to merge 1 commit into from
+26 −0

Conversation

lucarlig
Copy link
Member

@lucarlig lucarlig commented Aug 5, 2025 •
edited
Loading

added regression test using LLVM IR

https://rust.godbolt.org/z/7qcEKPf3e

Fixes #69174
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2025
Mark-Simulacrum
Mark-Simulacrum requested changes Aug 21, 2025
View reviewed changes
tests/codegen-llvm/derive-clone-enum-variants.rs
}

// CHECK-LABEL: @clone_bar
// CHECK-NOT: icmp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust this to specifically check this is just a load + ret? That should be fairly future proof and avoids any regressions if this is something that's more complex but not an icmp.

 %0 = load i16, ptr %b, align 1 ret i16 %0
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025
@Dylan-DPC
Copy link
Member

@lucarlig any updates on this? thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants

@lucarlig @rustbot @Dylan-DPC @Mark-Simulacrum