Limit impl_trait_header query to only trait impls

[camsteffen]

Changes impl_trait_header to panic on inherent impls intstead of returning None. A few downstream functions are split into option and non-option returning functions. This gets rid of a lot of unwraps where we know we have a trait impl, while there are still some cases where the Option is helpful.

Summary of changes to tcx methods:

• impl_is_of_trait (new)
• impl_trait_header -> impl_trait_header/impl_opt_trait_header
• impl_trait_ref -> impl_trait_ref/impl_opt_trait_ref
• trait_id_of_impl -> impl_trait_id/impl_opt_trait_id

[rustbot]

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

HIR ty lowering was modified

cc @fmease

[lqd]

@bors try @rust-timer queue

[rust-bors]

⌛ Trying commit c4b4025 with merge a9207a1…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

💔 Test failed (CI). Failed jobs:

• bors build finished (web logs, extended logs)
• try - dist-x86_64-linux (web logs, extended logs)

[camsteffen]

@bors try @rust-timer queue

[rust-bors]

@camsteffen: 🔑 Insufficient privileges: not in try users

[lqd]

@bors try @rust-timer queue

[rust-bors]

⌛ Trying commit 35dbd1a with merge 60b45cb…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 60b45cb (60b45cbaa7a7f0ea8340063c9bbac4ed081c245a, parent: cdccba87bf9ad5d87c1417eeb8fa52a4b614bbf9)

[rust-timer]

Finished benchmarking commit (60b45cb): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

• eza-0.21.2
• externs
• include-blob
• clap_derive-4.5.32
• serde-1.0.219
• wg-grammar
• syn-2.0.101
• unify-linearly
• ucd
• serde_derive-1.0.219
• cranelift-codegen-0.119.0
• regression-31157
• diesel-2.2.10
• bitmaps-3.2.1
• hyper-1.6.0
• ripgrep-14.1.1
• tuple-stress
• match-stress
• ctfe-stress-5
• derive
• deeply-nested-multi
• helloworld
• unicode-normalization-0.1.24
• wf-projection-stress-65510
• coercions
• stm32f4-0.15.1
• issue-58319
• html5ever-0.31.0
• projection-caching
• token-stream-stress
• tt-muncher
• serde-1.0.219-threads4
• large-workspace
• nalgebra-0.33.0
• many-assoc-items
• issue-46449
• image-0.25.6
• cargo-0.87.1
• typenum-1.18.0
• unused-warnings
• await-call-tree
• regex-automata-0.4.8
• issue-88862
• deep-vector
• libc-0.2.172

❗ ❗ ❗ ❗ ❗

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.2%, 3.7%]	9
Regressions ❌ (secondary)	0.5%	[0.4%, 0.5%]	3
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	2.1%	[-0.2%, 3.7%]	10

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.1%, -2.3%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.046s -> 466.887s (-0.46%)
Artifact size: 376.81 MiB -> 376.87 MiB (0.02%)

[camsteffen]

Y'all think that's funny? 😤

Fixed the rustdoc issues from above.

[camsteffen]

Replied and added some fixup commits that can be squashed.

I do feel like it would have been nice to initially simply rename the query to opt_impl_trait_ref and change impl_trait_ref to simply call that query and unwrap so that this change can be separately reviewed and merged.

Yeah that's fair. I did kinda do that with separate commits except I lumped in some changes to not use opt along with the rename. It seemed silly to do a simple rename that would leave opt().unwrap() so I guess I fixed those with the rename and then decided I may as well throw in more changes.

[lcnr]

r=me after reverting the one change

@bors delegate+

[bors]

✌️ @camsteffen, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, please make that change, then do @bors r=@lcnr

[camsteffen]

@bors r=lcnr

[bors]

📌 Commit d111d39 has been approved by lcnr

It is now in the queue for this repository.

[camsteffen]

@bors r- this will need a rebase after the Clippy update

[bors]

☔ The latest upstream changes (presumably #147779) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[camsteffen]

@bors r=lcnr

[bors]

📌 Commit d9a5389 has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit d9a5389 with merge 2170b4d...