Skip to content

Enable const-vector.rs test on RISC-V (riscv64) #144283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CaiWeiran wants to merge 1 commit into from
Closed

Enable const-vector.rs test on RISC-V (riscv64) #144283

CaiWeiran wants to merge 1 commit into from

Conversation

@CaiWeiran
Copy link

@CaiWeiran CaiWeiran commented Jul 22, 2025

This PR adds support for running the tests/codegen/const-vector.rs test on the RISC-V (riscv64) architecture.

Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.

The change has been tested locally using ./x test on a riscv64 target, and the test now passes as expected.

Notes:

  • This change is scoped specifically to improve RISC-V compatibility.
  • It does not affect behavior or test results on other architectures.
@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 22, 2025
@wesleywiser
Copy link
Member

wesleywiser commented Jul 22, 2025

Thanks @CaiWeiran!

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Jul 22, 2025

📌 Commit 5d1b98d has been approved by wesleywiser

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2025
@bors
Copy link
Collaborator

bors commented Jul 22, 2025

☔ The latest upstream changes (presumably #144249) made this pull request unmergeable. Please resolve the merge conflicts.
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2025
@CaiWeiran CaiWeiran force-pushed the const-vector_test branch from 5d1b98d to a8380f7 Compare July 23, 2025 01:25
@CaiWeiran CaiWeiran closed this Jul 23, 2025
@CaiWeiran CaiWeiran deleted the const-vector_test branch July 23, 2025 01:36
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 23, 2025
@CaiWeiran CaiWeiran mentioned this pull request Jul 23, 2025
Merged
Kobzol added a commit to Kobzol/rust that referenced this pull request Jul 25, 2025
@Kobzol
Rollup merge of rust-lang#144341 - CaiWeiran:const-vector_test, r=wes…
38066ad 
…leywiser Enable const-vector.rs test on RISC-V (riscv64) This PR replaces [rust-lang#144283](rust-lang#144283) to resolve merge conflicts. This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture. Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent. The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected. ### Notes: - This change is scoped specifically to improve RISC-V compatibility. - It does not affect behavior or test results on other architectures.
tgross35 added a commit to tgross35/rust that referenced this pull request Jul 26, 2025
@tgross35
Rollup merge of rust-lang#144341 - CaiWeiran:const-vector_test, r=wes…
a262dad 
…leywiser Enable const-vector.rs test on RISC-V (riscv64) This PR replaces [rust-lang#144283](rust-lang#144283) to resolve merge conflicts. This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture. Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent. The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected. ### Notes: - This change is scoped specifically to improve RISC-V compatibility. - It does not affect behavior or test results on other architectures.
rust-timer added a commit that referenced this pull request Jul 26, 2025
@rust-timer
Unrolled build for #144341
f47fdc1 
Rollup merge of #144341 - CaiWeiran:const-vector_test, r=wesleywiser Enable const-vector.rs test on RISC-V (riscv64) This PR replaces [#144283](#144283) to resolve merge conflicts. This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture. Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent. The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected. ### Notes: - This change is scoped specifically to improve RISC-V compatibility. - It does not affect behavior or test results on other architectures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants

@CaiWeiran @rustbot @wesleywiser @bors @Mark-Simulacrum