Skip to content

Add implicit sized bound to trait ascription types #144142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2025
Merged

Add implicit sized bound to trait ascription types #144142

merged 1 commit into from
Jul 20, 2025

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jul 18, 2025 •
edited by rustbot
Loading

r? @fmease or reassign

Thanks for catching this :)

Fixes #144135
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

fmease is currently at their maximum review capacity.
They may take a while to respond.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

HIR ty lowering was modified

cc @fmease
@fmease
Copy link
Member

fmease commented Jul 18, 2025

Thanks errs! :) @bors r+ rollup (unstable)
@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit 4cebbab has been approved by fmease

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 20, 2025
@jhpratt
Rollup merge of rust-lang#144142 - compiler-errors:itib, r=fmease
aca16bf 
Add implicit sized bound to trait ascription types r? `@fmease` or reassign Thanks for catching this :) Fixes rust-lang#144135
@jhpratt jhpratt mentioned this pull request Jul 20, 2025
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 20, 2025
@fee1-dead
Rollup merge of rust-lang#144142 - compiler-errors:itib, r=fmease
785038d 
Add implicit sized bound to trait ascription types r? ``@fmease`` or reassign Thanks for catching this :) Fixes rust-lang#144135
@fee1-dead fee1-dead mentioned this pull request Jul 20, 2025
Closed
bors added a commit that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144204 - fee1-dead-contrib:rollup-56951om, r=fee1-dead
cbf0987 
Rollup of 12 pull requests Successful merges: - #141260 (Allow volatile access to non-Rust memory, including address 0) - #143604 (Stabilize `const_float_round_methods`) - #143833 (Ban projecting into SIMD types [MCP838]) - #143988 ([rustdoc] Make aliases search support partial matching) - #144078 (Fix debuginfo-lto-alloc.rs test) - #144111 (Remove deprecated `MaybeUninit` slice methods) - #144116 (Fixes for LLVM 21) - #144134 (Cleanup unicode table gen) - #144142 (Add implicit sized bound to trait ascription types) - #144148 (Remove pretty print hack for async blocks) - #144169 (interpret: fix TypeId pointers being considered data pointers) - #144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2025
Merged
bors added a commit that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144208 - matthiaskrgr:rollup-wrli87h, r=matthiaskrgr
ca9eecd 
Rollup of 11 pull requests Successful merges: - #141260 (Allow volatile access to non-Rust memory, including address 0) - #143604 (Stabilize `const_float_round_methods`) - #143988 ([rustdoc] Make aliases search support partial matching) - #144078 (Fix debuginfo-lto-alloc.rs test) - #144111 (Remove deprecated `MaybeUninit` slice methods) - #144116 (Fixes for LLVM 21) - #144134 (Cleanup unicode table gen) - #144142 (Add implicit sized bound to trait ascription types) - #144148 (Remove pretty print hack for async blocks) - #144169 (interpret: fix TypeId pointers being considered data pointers) - #144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 23c81a7 into rust-lang:master Jul 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 20, 2025
rust-timer added a commit that referenced this pull request Jul 20, 2025
@rust-timer
Unrolled build for #144142
2fe1973 
Rollup merge of #144142 - compiler-errors:itib, r=fmease Add implicit sized bound to trait ascription types r? ```@fmease``` or reassign Thanks for catching this :) Fixes #144135
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144208 - matthiaskrgr:rollup-wrli87h, r=matthiaskrgr
bc32ee0 
Rollup of 11 pull requests Successful merges: - rust-lang/rust#141260 (Allow volatile access to non-Rust memory, including address 0) - rust-lang/rust#143604 (Stabilize `const_float_round_methods`) - rust-lang/rust#143988 ([rustdoc] Make aliases search support partial matching) - rust-lang/rust#144078 (Fix debuginfo-lto-alloc.rs test) - rust-lang/rust#144111 (Remove deprecated `MaybeUninit` slice methods) - rust-lang/rust#144116 (Fixes for LLVM 21) - rust-lang/rust#144134 (Cleanup unicode table gen) - rust-lang/rust#144142 (Add implicit sized bound to trait ascription types) - rust-lang/rust#144148 (Remove pretty print hack for async blocks) - rust-lang/rust#144169 (interpret: fix TypeId pointers being considered data pointers) - rust-lang/rust#144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@matthiaskrgr @Muscraft
Rollup merge of rust-lang#144142 - compiler-errors:itib, r=fmease
0ed8a23 
Add implicit sized bound to trait ascription types r? ```@fmease``` or reassign Thanks for catching this :) Fixes rust-lang#144135
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144208 - matthiaskrgr:rollup-wrli87h, r=matth…
6519063 
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#141260 (Allow volatile access to non-Rust memory, including address 0) - rust-lang#143604 (Stabilize `const_float_round_methods`) - rust-lang#143988 ([rustdoc] Make aliases search support partial matching) - rust-lang#144078 (Fix debuginfo-lto-alloc.rs test) - rust-lang#144111 (Remove deprecated `MaybeUninit` slice methods) - rust-lang#144116 (Fixes for LLVM 21) - rust-lang#144134 (Cleanup unicode table gen) - rust-lang#144142 (Add implicit sized bound to trait ascription types) - rust-lang#144148 (Remove pretty print hack for async blocks) - rust-lang#144169 (interpret: fix TypeId pointers being considered data pointers) - rust-lang#144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants

@compiler-errors @rustbot @fmease @bors