Use "Innermost" & "Outermost" terminology for AttributeOrder #143659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added A-attributes | Some changes occurred in compiler/rustc_attr_parsing |
| @bors r+ rollup |
bors added S-waiting-on-bors 
bors added a commit that referenced this pull request Jul 10, 2025
Rollup of 12 pull requests Successful merges: - #136906 (Add checking for unnecessary delims in closure body) - #143652 (docs: document trait upcasting rules in `Unsize` trait) - #143657 (Resolver: refact macro map into external and local maps) - #143659 (Use "Innermost" & "Outermost" terminology for `AttributeOrder`) - #143663 (fix: correct typo in attr_parsing_previously_accepted message key) - #143666 (Re-expose nested bodies in rustc_borrowck::consumers) - #143668 (Fix VxWorks build errors) - #143670 (Add a new maintainer to the wasm32-wasip1 target) - #143675 (improve lint doc text) - #143683 (Assorted `run-make-support` maintenance) - #143695 (Auto-add `S-waiting-on-author` when the PR is/switches to draft state) - #143706 (triagebot.toml: ping lolbinarycat if tidy extra checks were modified) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request Jul 10, 2025
Rollup merge of #143659 - GrigorenkoPV:attributes/inner-outer, r=jdonszelmann Use "Innermost" & "Outermost" terminology for `AttributeOrder` Follow-up to #143603. https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/attribute.20parsing.20rework/near/527768926 Also remove some outdated comments. cc `@jdonszelmann`
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 15, 2025
Rollup of 12 pull requests Successful merges: - rust-lang/rust#136906 (Add checking for unnecessary delims in closure body) - rust-lang/rust#143652 (docs: document trait upcasting rules in `Unsize` trait) - rust-lang/rust#143657 (Resolver: refact macro map into external and local maps) - rust-lang/rust#143659 (Use "Innermost" & "Outermost" terminology for `AttributeOrder`) - rust-lang/rust#143663 (fix: correct typo in attr_parsing_previously_accepted message key) - rust-lang/rust#143666 (Re-expose nested bodies in rustc_borrowck::consumers) - rust-lang/rust#143668 (Fix VxWorks build errors) - rust-lang/rust#143670 (Add a new maintainer to the wasm32-wasip1 target) - rust-lang/rust#143675 (improve lint doc text) - rust-lang/rust#143683 (Assorted `run-make-support` maintenance) - rust-lang/rust#143695 (Auto-add `S-waiting-on-author` when the PR is/switches to draft state) - rust-lang/rust#143706 (triagebot.toml: ping lolbinarycat if tidy extra checks were modified) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow-up to #143603.
https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/attribute.20parsing.20rework/near/527768926
Also remove some outdated comments. cc @jdonszelmann