Skip to content

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Jul 5, 2025

Resumption of #141979, making the test cross-compile.

@YingkaiLi-VM My apologies if this is undesired. 64bec0f was the two lines of difference needed. Feel free to reopen a new version of your PR if you would rather rebase and fix it up again.

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2025
@rust-log-analyzer

This comment has been minimized.

@workingjubilee workingjubilee force-pushed the make-debug-rs-cross-compile branch from 2f41577 to 64bec0f Compare July 5, 2025 01:14
@workingjubilee
Copy link
Member Author

Two lines.

@YingkaiLi-VM
Copy link
Contributor

@workingjubilee As a newcomer to the Rust community and related work, I realize our PR discussions might have contained some miscommunications – I sincerely appreciate your time and patience throughout. Thank you especially for your revisions to the PR!
Could you clarify whether I still need to make any changes to it?
Truly appreciate your guidance.

@workingjubilee
Copy link
Member Author

@YingkaiLi-VM If you are happy with this PR as it is then you need do nothing. My apologies again for the confusion.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 7, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit 64bec0f has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
bors added a commit that referenced this pull request Jul 7, 2025
Rollup of 11 pull requests Successful merges: - #143130 (doc(std): clarify `NonZero<T>` usage limitation in doc comment) - #143415 (Get rid of build-powerpc64le-toolchain.sh) - #143464 (Make tests/ui/abi/debug.rs cross-compile) - #143482 (Fix short linker error output) - #143524 (Move `stable_mir` back to its own crate) - #143528 (interpret: rename StackPopCleanup) - #143551 (Dont resolve instance of root in `mir_callgraph_cyclic`) - #143558 (mbe: Refactors and function extractions in `compile_declarative_macro`) - #143563 (std: fix typo in `std::path`) - #143564 (compiler: Deduplicate `must_emit_unwind_tables()` comments) - #143577 (Disable download-rustc for library profile) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit fc13c96 into rust-lang:master Jul 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 7, 2025
rust-timer added a commit that referenced this pull request Jul 7, 2025
Rollup merge of #143464 - workingjubilee:make-debug-rs-cross-compile, r=oli-obk Make tests/ui/abi/debug.rs cross-compile Resumption of #141979, making the test cross-compile.
github-actions bot pushed a commit to devnexen/miri that referenced this pull request Jul 8, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#143130 (doc(std): clarify `NonZero<T>` usage limitation in doc comment) - rust-lang/rust#143415 (Get rid of build-powerpc64le-toolchain.sh) - rust-lang/rust#143464 (Make tests/ui/abi/debug.rs cross-compile) - rust-lang/rust#143482 (Fix short linker error output) - rust-lang/rust#143524 (Move `stable_mir` back to its own crate) - rust-lang/rust#143528 (interpret: rename StackPopCleanup) - rust-lang/rust#143551 (Dont resolve instance of root in `mir_callgraph_cyclic`) - rust-lang/rust#143558 (mbe: Refactors and function extractions in `compile_declarative_macro`) - rust-lang/rust#143563 (std: fix typo in `std::path`) - rust-lang/rust#143564 (compiler: Deduplicate `must_emit_unwind_tables()` comments) - rust-lang/rust#143577 (Disable download-rustc for library profile) r? `@ghost` `@rustbot` modify labels: rollup
@workingjubilee workingjubilee deleted the make-debug-rs-cross-compile branch July 10, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

6 participants