Skip to content

Show AtomicU128/AtomicI128 in std docs regardless of target #143439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show AtomicU128/AtomicI128 in std docs regardless of target #143439

wants to merge 2 commits into from

Conversation

Mtfl0n
Copy link

@Mtfl0n Mtfl0n commented Jul 4, 2025 •
edited by rustbot
Loading

Fixes #130474

Ensures AtomicU128 and AtomicI128 appear in documentation even when docs are built for targets without native 128-bit atomic support (like x86_64-unknown-linux-gnu). The fix adds cfg(doc) to existing conditional compilation checks.

Changes:

  • Added cfg(doc) to #[cfg(target_has_atomic_load_store = "128")]
  • Added cfg(doc) to internal cfg(target_has_atomic = "128") in atomic_int! macro
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] ____ test:false 0.024 [COPY] stdlib source [PATCH] "stdlib" <- "0027-stdlib-128bit-atomic-operations.patch" error: patch failed: library/core/src/sync/atomic.rs:3585 error: library/core/src/sync/atomic.rs: patch does not apply hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config advice.mergeConflict false" Patch failed at 0001 Disable 128bit atomic operations cd "/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools/cg_clif/build/stdlib" && "git" "-c" "user.name=Dummy" "-c" "user.email=dummy@example.com" "-c" "core.autocrlf=false" "-c" "commit.gpgSign=false" "am" "/checkout/compiler/rustc_codegen_cranelift/patches/0027-stdlib-128bit-atomic-operations.patch" "-q" exited with status ExitStatus(unix_wait_status(32768)) Command has failed. Rerun with -v to see more details. Build completed unsuccessfully in 0:11:32 local time: Fri Jul 4 17:25:45 UTC 2025 network time: Fri, 04 Jul 2025 17:25:45 GMT ##[error]Process completed with exit code 1. Post job cleanup.
@tgross35
Copy link
Contributor

Could you update the 0027-stdlib-128bit-atomic-operations.patch patchfile for these changes? Also probably needs a rebase
@ibraheemdev ibraheemdev added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025
@Dylan-DPC
Copy link
Member

@Mtfl0n any updates on this? thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

6 participants

@Mtfl0n @rustbot @rust-log-analyzer @tgross35 @Dylan-DPC @ibraheemdev