Fix x clean with a fifo #143288
Merged
Fix x clean with a fifo #143288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`x clean` was failing when it encountered a special file like a fifo because it thought it was a directory.
| rustbot has assigned @Mark-Simulacrum. Use |
rustbot added S-waiting-on-review 
| @bors r+ rollup |
bors added S-waiting-on-bors 
| Isn't this reverting efd6eab? |
| @bors r- Can you say more about what seems to be reverted? Just from a quick glance, it looks like this still does not follow symlinks. |
bors added S-waiting-on-author | Sorry, I was just trying to understand why the original PR was written that way. I thought it was trying to handle a symlink special case on Windows (where |
| I kinda wonder if this implementation can be replaced with (This PR itself is fine I think) |
| Ok, I'll go ahead and move this forward. @bors r=Kobzol |
bors added S-waiting-on-bors 
bors added a commit that referenced this pull request Jul 4, 2025
Rollup of 11 pull requests Successful merges: - #142749 (Add methods for converting bool to `Result<(), E>`) - #143288 (Fix `x clean` with a fifo) - #143307 (Fast path nitpicks) - #143346 (update coherence example) - #143356 (use unsigned_abs instead of `abs` on signed int to silence clippy) - #143370 (remove redundant #[must_use]) - #143378 (simplify receivers for some array method calls) - #143380 (Replace kw_span by full span for generic const parameters.) - #143381 (rustdoc: don't treat methods under const impls or traits as const) - #143394 (compiler: Document and reduce `fn provide`s in hir crates) - #143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request Jul 4, 2025
Rollup merge of #143288 - ehuss:fix-clean-fifo, r=Kobzol Fix `x clean` with a fifo `x clean` was failing when it encountered a special file like a fifo because it thought it was a directory.
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jul 4, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#142749 (Add methods for converting bool to `Result<(), E>`) - rust-lang/rust#143288 (Fix `x clean` with a fifo) - rust-lang/rust#143307 (Fast path nitpicks) - rust-lang/rust#143346 (update coherence example) - rust-lang/rust#143356 (use unsigned_abs instead of `abs` on signed int to silence clippy) - rust-lang/rust#143370 (remove redundant #[must_use]) - rust-lang/rust#143378 (simplify receivers for some array method calls) - rust-lang/rust#143380 (Replace kw_span by full span for generic const parameters.) - rust-lang/rust#143381 (rustdoc: don't treat methods under const impls or traits as const) - rust-lang/rust#143394 (compiler: Document and reduce `fn provide`s in hir crates) - rust-lang/rust#143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
x cleanwas failing when it encountered a special file like a fifo because it thought it was a directory.