Subtree update of rust-analyzer #142907
Merged
Subtree update of rust-analyzer #142907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…hen possible But default to not to. I chose to have a more generic config name because maybe other assists could also use the same approach.
…private-field diagnostic (previously it was only on no-such-field) The difference between the diagnostics is that no-such-field is for record struct construction, while private-field is for dot syntax. I tried to unify them, but there is a bit of uniqueness in each. This is possible but maybe not worth it. Also, fix the quickfix when there is already a visibility to the field (replace it instead of appending to it).
feat: Show what cargo metadata is doing in status
feat: Insert required parentheses when typing `+` in dyn trait type
…-quickfix feat: Add the quickfix for increasing visibility of a private field to the private-field diagnostic (previously it was only on no-such-field)
feat: In "Fill match arms", allow users to prefer `Self` to the enum name when possible
fix: Copy lockfiles into target directory before invoking `cargo metadata`
chore: Start infesting ide crates with 'db lifetime
fix: Reload workspaces when cargo configs change
We show fixes now even for experimental diagnostics anyway, and it has false positives.
…-exp fix: Never make type mismatch diagnostic stable, even when there is a fix
Improve completions in if / while expression conditions
…s_without_pe Hide imported privates if private editable is disabled
minor: Sync from downstream
fix: Closure capturing for let exprs
This reverts commit 8643a858dbaf12b37e90b603cdee64434576c229.
Revert "Turn `BlockId` into a `#[salsa::tracked]`"
fix: Temporarily disable `+` typing handler as it moves the cursor position
Add --color=always to test explorer command
…getter Add `fn parent(self, db) -> GenericDef` to `hir::TypeParam`
fix: Correct grammar in remove all unused imports assist
internal: Utilize `cargo check --compile-time-deps`
…de-imports-in-symbol-search Add better documentation for excluding imports from symbol search
Minic rustc's new `format_args!` expansion
rustbot added the S-waiting-on-review 
Collaborator
| rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
Member Author
| @bors r+ p=1 subtree sync |
Collaborator
bors added S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 42245d3 (parent) -> 706f244 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 706f244db581212cabf2e619e0113d70999b2bbe --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
| Finished benchmarking commit (706f244): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.4%, secondary 1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 1.4%, secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 688.878s -> 688.989s (0.02%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
r? @ghost