Improved error message for top-level or-patterns #140848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| rustbot has assigned @compiler-errors. Use |
rustbot added S-waiting-on-review 
compiler-errors approved these changes May 9, 2025
| thanks! @bors r+ rollup |
bors added S-waiting-on-bors 
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 9, 2025
…er-errors Improved error message for top-level or-patterns I was confused by "top-level or-patterns are not allowed in `let` bindings" error, because it sounded like or-patterns were completely unsupported. This error has an auto-fix suggestion that shows otherwise, but the auto-fix isn't always visible in IDEs. I've changed the wording to be consistent with "`Fn` bounds require arguments in parentheses", and it doesn't sound like a dead-end any more.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#139863 (rustdoc: Replace unstable flag `--doctest-compilation-args` with a simpler one: `--doctest-build-arg`) - rust-lang#140815 (also export metrics from librustdoc) - rust-lang#140819 (Add regression test for 125877) - rust-lang#140843 (Fix `broken-pipe-no-ice` run-make test for rpath-less builds) - rust-lang#140848 (Improved error message for top-level or-patterns) - rust-lang#140852 (Update the edition guide for let chains) - rust-lang#140864 (Last minute relnotes fix) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
Rollup merge of rust-lang#140848 - kornelski:not-a-dead-end, r=compiler-errors Improved error message for top-level or-patterns I was confused by "top-level or-patterns are not allowed in `let` bindings" error, because it sounded like or-patterns were completely unsupported. This error has an auto-fix suggestion that shows otherwise, but the auto-fix isn't always visible in IDEs. I've changed the wording to be consistent with "`Fn` bounds require arguments in parentheses", and it doesn't sound like a dead-end any more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was confused by "top-level or-patterns are not allowed in
letbindings" error, because it sounded like or-patterns were completely unsupported.This error has an auto-fix suggestion that shows otherwise, but the auto-fix isn't always visible in IDEs.
I've changed the wording to be consistent with "
Fnbounds require arguments in parentheses", and it doesn't sound like a dead-end any more.