Skip to content

Do not insert duplicate SourceFile #140363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not insert duplicate SourceFile #140363

wants to merge 1 commit into from
+22 −15

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 27, 2025

This is a rebase of #115572 which fixes a race by checking if a source file is already present before adding it.
@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the pr115572-rebase branch 4 times, most recently from 64687cb to 8595616 Compare April 27, 2025 13:17
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the pr115572-rebase branch from 8595616 to 08041ac Compare April 27, 2025 13:49
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with CI passing
@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2025
@Zoxc Zoxc force-pushed the pr115572-rebase branch from 08041ac to 46890ac Compare May 7, 2025 22:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the pr115572-rebase branch from 46890ac to 2df339b Compare May 8, 2025 00:09
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the pr115572-rebase branch from 2df339b to 4bf5cd1 Compare May 8, 2025 00:36
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot @Zoxc
Do not insert duplicate file.
136f8b9 
Co-authored-by: John Kåre Alsaker <john.kare.alsaker@gmail.com>
@Zoxc Zoxc force-pushed the pr115572-rebase branch from 4bf5cd1 to 136f8b9 Compare May 8, 2025 00:58
@karolzwolak
Copy link
Member

Thanks for your contribution @Zoxc from wg-triage.
Any updates on this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

7 participants

@Zoxc @rustbot @rust-log-analyzer @karolzwolak @davidtwco @compiler-errors @cjgillot