Skip to content

Use posix_spawn on cygwin #139617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Use posix_spawn on cygwin #139617

merged 1 commit into from
Apr 23, 2025

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Apr 10, 2025 •
edited
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 10, 2025
@joboet
Copy link
Member

joboet commented Apr 19, 2025

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Apr 19, 2025

📌 Commit 7aab011 has been approved by joboet

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2025
@joboet
Copy link
Member

joboet commented Apr 19, 2025

Oh wait, this still needs to update libc.
@bors r-
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2025
@Berrysoft
Copy link
Contributor Author

libc has been updated: #139969
@Berrysoft
Copy link
Contributor Author

@rustbot ready
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2025
@joboet
Copy link
Member

joboet commented Apr 20, 2025

libc has been updated: #139969

That only affected the libc used by the compiler. The library crates use their own lockfile, so you'll need to adjust std's Cargo.toml as well.
@Berrysoft
Copy link
Contributor Author

OK, I've opened a PR: #140081
@Berrysoft
Copy link
Contributor Author

It should be ready.
@joboet
Copy link
Member

joboet commented Apr 22, 2025

Great!
@bors r+
@bors
Copy link
Collaborator

bors commented Apr 22, 2025

📌 Commit 7aab011 has been approved by joboet

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 22, 2025
@ChrisDenton
Rollup merge of rust-lang#139617 - Berrysoft:cygwin-posix-spawn, r=jo…
22907be 
…boet Use posix_spawn on cygwin r? `@joboet` Depends on: - [x] rust-lang/libc#4387 - [x] rust-lang#140081
@ChrisDenton ChrisDenton mentioned this pull request Apr 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
@bors
Auto merge of rust-lang#140161 - ChrisDenton:rollup-krbf3er, r=ChrisD…
6d35f2a 
…enton Rollup of 8 pull requests Successful merges: - rust-lang#139309 (make abi_unsupported_vector_types a hard error) - rust-lang#139617 (Use posix_spawn on cygwin) - rust-lang#140072 (handle function alignment in miri) - rust-lang#140104 (Fix auto diff failing on inherent impl blocks) - rust-lang#140124 (Update books) - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.) - rust-lang#140146 (Update `compiler_builtins` to 0.1.156) - rust-lang#140149 (test_nan: ensure the NAN contant is quiet) r? `@ghost` `@rustbot` modify labels: rollup
@ChrisDenton ChrisDenton mentioned this pull request Apr 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
@bors
Auto merge of rust-lang#140165 - ChrisDenton:rollup-on2dpr5, r=ChrisD…
6a3a8b8 
…enton Rollup of 8 pull requests Successful merges: - rust-lang#139617 (Use posix_spawn on cygwin) - rust-lang#139921 (improve diagnostic for raw pointer field access with ->) - rust-lang#140031 (compiletest: Fix deadline bugs in new executor) - rust-lang#140072 (handle function alignment in miri) - rust-lang#140104 (Fix auto diff failing on inherent impl blocks) - rust-lang#140124 (Update books) - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.) - rust-lang#140149 (test_nan: ensure the NAN contant is quiet) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
@bors
Auto merge of rust-lang#140165 - ChrisDenton:rollup-on2dpr5, r=ChrisD…
1a5bf12 
…enton Rollup of 8 pull requests Successful merges: - rust-lang#139617 (Use posix_spawn on cygwin) - rust-lang#139921 (improve diagnostic for raw pointer field access with ->) - rust-lang#140031 (compiletest: Fix deadline bugs in new executor) - rust-lang#140072 (handle function alignment in miri) - rust-lang#140104 (Fix auto diff failing on inherent impl blocks) - rust-lang#140124 (Update books) - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.) - rust-lang#140149 (test_nan: ensure the NAN contant is quiet) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 1586660 into rust-lang:master Apr 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 23, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2025
@rust-timer
Unrolled build for rust-lang#139617
d7edba8 
Rollup merge of rust-lang#139617 - Berrysoft:cygwin-posix-spawn, r=joboet Use posix_spawn on cygwin r? ``@joboet`` Depends on: - [x] rust-lang/libc#4387 - [x] rust-lang#140081
@Berrysoft Berrysoft deleted the cygwin-posix-spawn branch April 23, 2025 01:32
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 24, 2025
@ChrisDenton
Rollup merge of rust-lang#139617 - Berrysoft:cygwin-posix-spawn, r=jo…
adc93e0 
…boet Use posix_spawn on cygwin r? ``@joboet`` Depends on: - [x] rust-lang/libc#4387 - [x] rust-lang#140081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

4 participants

@Berrysoft @joboet @bors @rustbot