Skip to content

Add unstable --print=crate-root-lint-levels #139184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

Add unstable --print=crate-root-lint-levels #139184

merged 3 commits into from
Apr 2, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Mar 31, 2025

This PR implements --print=crate-root-lint-levels from MCP 833 rust-lang/compiler-team#833.

Tracking issue: #139180

Best reviewed commit by commit.
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

This PR modifies run-make tests.

cc @jieyouxu
@Urgau Urgau mentioned this pull request Mar 31, 2025
Open
3 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau force-pushed the crate-root-lint-levels branch from 7c6f565 to ecf46ff Compare March 31, 2025 17:52
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau force-pushed the crate-root-lint-levels branch from ecf46ff to bf62be2 Compare March 31, 2025 19:01
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau Urgau force-pushed the crate-root-lint-levels branch from bf62be2 to 831a158 Compare March 31, 2025 20:16
@Urgau Urgau force-pushed the crate-root-lint-levels branch from 831a158 to df18de5 Compare April 1, 2025 16:29
jieyouxu
jieyouxu approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM mostly, have a few more questions
@jieyouxu
Copy link
Member

jieyouxu commented Apr 1, 2025

@rustbot author
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 1, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 2, 2025

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit df18de5 has been approved by jieyouxu

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#139184 - Urgau:crate-root-lint-levels, r=ji…
4cce692 
…eyouxu Add unstable `--print=crate-root-lint-levels` This PR implements `--print=crate-root-lint-levels` from MCP 833 rust-lang/compiler-team#833. Tracking issue: rust-lang#139180 Best reviewed commit by commit.
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 2, 2025
Closed
@TaKO8Ki TaKO8Ki mentioned this pull request Apr 2, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@bors
Auto merge of rust-lang#139257 - TaKO8Ki:rollup-vjzdas7, r=TaKO8Ki
4f0de4c 
Rollup of 5 pull requests Successful merges: - rust-lang#139178 (Remove cjgillot from automated review assignment) - rust-lang#139184 (Add unstable `--print=crate-root-lint-levels`) - rust-lang#139215 (Add `opt-level = "s"` for more std symbolication crates) - rust-lang#139232 (Move methods from `Map` to `TyCtxt`, part 5.) - rust-lang#139239 (Remove `aux_build` run-make rustc helpers) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit eb23a59 into rust-lang:master Apr 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@rust-timer
Unrolled build for rust-lang#139184
8713ba6 
Rollup merge of rust-lang#139184 - Urgau:crate-root-lint-levels, r=jieyouxu Add unstable `--print=crate-root-lint-levels` This PR implements `--print=crate-root-lint-levels` from MCP 833 rust-lang/compiler-team#833. Tracking issue: rust-lang#139180 Best reviewed commit by commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants

@Urgau @rustbot @rust-log-analyzer @jieyouxu @bors