Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
a56b1d2
fix missing rustfmt and clippy for msi
heiseish Oct 7, 2024
a0abd61
fix missing rustfmt for apple darwin
heiseish Oct 7, 2024
43152ad
wix: allow to skip more components
klensy Nov 16, 2024
55239b5
adjust comment
heiseish Mar 17, 2025
0ee9456
fix download-llvm logic for subtree sync branches
RalfJung Mar 17, 2025
6362851
[bootstrap] Distribute split debuginfo if present
wesleywiser May 1, 2024
3bfb6af
Test windows file type equality
ChrisDenton Mar 18, 2025
6b2fa32
Windows: fix FileType PartialEq implementation
ChrisDenton Mar 18, 2025
b54ca0e
Add a MIR pre-codegen test for tuple comparisons
scottmcm Mar 6, 2025
35248c6
Add chaining versions of lt/le/gt/ge and use them in tuple PartialOrd
scottmcm Mar 6, 2025
521d0c4
Cache current_dll_path output
bjorn3 Mar 21, 2025
63cfd47
Don't attempt to export compiler-builtins symbols from rust dylibs
bjorn3 Feb 27, 2025
530ab61
Also check for compiler-builtins in linked_symbols
bjorn3 Mar 21, 2025
b46412f
rustdoc: be more strict about "Methods from Deref"
lolbinarycat Mar 16, 2025
575f129
Obligation::as_goal
compiler-errors Mar 22, 2025
d588bc2
Don't super fold const in Resolver
compiler-errors Mar 22, 2025
fad34c6
Explicitly don't fold coroutine obligations in writeback
compiler-errors Mar 23, 2025
7781346
Stop using specialization for this
scottmcm Mar 23, 2025
95181ae
Update `compiler-builtins` to 0.1.152
tgross35 Mar 20, 2025
95994f9
Rollup merge of #137593 - RalfJung:subtree-sync-download-llvm, r=Mark…
jhpratt Mar 24, 2025
9a243cf
Rollup merge of #137736 - bjorn3:compiler_builtins_export_fix, r=petr…
jhpratt Mar 24, 2025
1ba9b78
Rollup merge of #138135 - scottmcm:chaining-ord, r=Mark-Simulacrum
jhpratt Mar 24, 2025
66f2a19
Rollup merge of #138321 - wesleywiser:bootstrap_package_pdbs, r=onur-…
jhpratt Mar 24, 2025
abc6784
Rollup merge of #138574 - lolbinarycat:rustdoc-deref-24686-v2, r=Guil…
jhpratt Mar 24, 2025
0fc6279
Rollup merge of #138606 - heiseish:131365-extended, r=Mark-Simulacrum
jhpratt Mar 24, 2025
8e30df7
Rollup merge of #138671 - ChrisDenton:filetype, r=joshtriplett
jhpratt Mar 24, 2025
b406d9a
Rollup merge of #138728 - tgross35:update-builtins, r=tgross35
jhpratt Mar 24, 2025
ab138e6
Rollup merge of #138783 - bjorn3:cache_current_dll_path, r=lqd
jhpratt Mar 24, 2025
0e95f96
Rollup merge of #138846 - compiler-errors:stall-prereqs, r=lcnr
jhpratt Mar 24, 2025
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix download-llvm logic for subtree sync branches
  • Loading branch information
RalfJung committed Mar 17, 2025
commit 0ee94562c9e7e2e75a13f06d9820cd191e21a06a
10 changes: 9 additions & 1 deletion src/build_helper/src/git.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ pub fn get_closest_merge_commit(
// cd \"/checkout\" && \"git\" \"merge-base\" \"origin/master\" \"HEAD\"\nexpected success, got: exit status: 1\n"
// ```
// Investigate and resolve this issue instead of skipping it like this.
// NOTE (2025-03): this is probably caused by CI using a sparse checkout.
(channel == "nightly" || !CiEnv::is_rust_lang_managed_ci_job())
{
git_upstream_merge_base(config, git_dir).unwrap()
Expand All @@ -150,11 +151,18 @@ pub fn get_closest_merge_commit(
}
};

// Now that rust-lang/rust is the only repo using bors, we can search the entire
// history for a bors commit, not just "first parents". This is crucial to make
// this logic work when the user has currently checked out a subtree sync branch.
// At the same time, we use this logic in CI where only a tiny part of the history
// is even checked out, making this kind of history search very fragile. It turns
// out that by adding `--diff-merges=first-parent`, we get a usable reply
// even for sparse checkouts: it will just return the most recent bors commit.
git.args([
"rev-list",
&format!("--author={}", config.git_merge_commit_email),
"-n1",
"--first-parent",
"--diff-merges=first-parent",
&merge_base,
]);

Expand Down
Loading