rustdoc-json: Don't also include #[deprecated] in Item::attrs #138577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This makes it clearer what it's actually used for, and makes it easier to think about modifying `Item::attributes`.
rustbot added A-rustdoc-json 
| For all my use cases, the behavior change will be invisible to my code and won't need a version bump. Given that deprecation attributes got changed to a debug-style repr in a prior version, I'd be surprised if anyone was relying on parsing that. But I won't be opposed to a bump if you think it's worth it. …On Sun, Mar 16, 2025, 3:32 PM Alona Enraght-Moony ***@***.***> wrote: Closes #138378 <#138378> Not sure if this should bump FORMAT_VERSION or not. CC @Enselic <https://github.com/Enselic> @LukeMathWalker <https://github.com/LukeMathWalker> @obi1kenobi <https://github.com/obi1kenobi> r? @GuillaumeGomez <https://github.com/GuillaumeGomez>, best reviewed commit-by-commit ------------------------------ You can view, comment on, or merge this pull request online at: #138577 Commit Summary - 2ff2815 <2ff2815> rustdoc-json: Add tests for `#[deprecated(...)]` - a8a913d <a8a913d> rustdoc: Rename `Item::attributes` param to `is_json` - 677489f <677489f> rustdoc-json: Don't also include `#[deprecated]` in `Item::attrs` File Changes (2 files <https://github.com/rust-lang/rust/pull/138577/files>) - *M* src/librustdoc/clean/types.rs <https://github.com/rust-lang/rust/pull/138577/files#diff-df9f90aae0b7769e1eb6ea6f1d73c1c3f649e1ac48a20e169662a8930eb427be> (23) - *A* tests/rustdoc-json/attrs/deprecated.rs <https://github.com/rust-lang/rust/pull/138577/files#diff-3184a6332a3dabf6875db4a23117828315e46d4ec305cb0c8561b6393904be4e> (38) Patch Links: - https://github.com/rust-lang/rust/pull/138577.patch - https://github.com/rust-lang/rust/pull/138577.diff — Reply to this email directly, view it on GitHub <#138577>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5MSS5SFYK2SP2KYQQYSD2UXUWVAVCNFSM6AAAAABZECIGY6VHI2DSMVQWIX3LMV43ASLTON2WKOZSHEZDGMZSGYYDEMY> . You are receiving this because you were mentioned.Message ID: ***@***.***> |
| I think it's fine to not bump but I don't mind if we end up doing it. |
| No preference on my side. Fine to skip bumping since there's already a dedicated field for that information. |
GuillaumeGomez approved these changes Mar 17, 2025
| Thanks! @bors r+ rollup |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133870 (Stabilize `asm_goto` feature gate) - rust-lang#137449 (Denote `ControlFlow` as `#[must_use]`) - rust-lang#137465 (mir_build: Avoid some useless work when visiting "primary" bindings) - rust-lang#138349 (Emit function declarations for functions with `#[linkage="extern_weak"]`) - rust-lang#138412 (Install licenses into `share/doc/rust/licenses`) - rust-lang#138577 (rustdoc-json: Don't also include `#[deprecated]` in `Item::attrs`) - rust-lang#138588 (Avoid double lowering of idents) Failed merges: - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2025
Rollup merge of rust-lang#138577 - aDotInTheVoid:deprecate-deprecations, r=GuillaumeGomez rustdoc-json: Don't also include `#[deprecated]` in `Item::attrs` Closes rust-lang#138378 Not sure if this should bump `FORMAT_VERSION` or not. CC `@Enselic` `@LukeMathWalker` `@obi1kenobi` r? `@GuillaumeGomez,` best reviewed commit-by-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #138378
Not sure if this should bump
FORMAT_VERSIONor not. CC @Enselic @LukeMathWalker @obi1kenobir? @GuillaumeGomez, best reviewed commit-by-commit