Skip to content

Implement Random for num::{Saturating,Wrapping} #136733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement Random for num::{Saturating,Wrapping} #136733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77de8b2
Implement `Random` for extra integer types
sorairolake Feb 8, 2025
dbd815a
Remove implementation of `Random` for `NonZero<T>`
sorairolake Feb 11, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions library/core/src/num/saturating.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use crate::ops::{
Add, AddAssign, BitAnd, BitAndAssign, BitOr, BitOrAssign, BitXor, BitXorAssign, Div, DivAssign,
Mul, MulAssign, Neg, Not, Rem, RemAssign, Sub, SubAssign,
};
use crate::random::{Random, RandomSource};

/// Provides intentionally-saturating arithmetic on `T`.
///
Expand Down Expand Up @@ -79,6 +80,13 @@ impl<T: fmt::UpperHex> fmt::UpperHex for Saturating<T> {
}
}

#[unstable(feature = "random", issue = "130703")]
impl<T: Random> Random for Saturating<T> {
fn random(source: &mut (impl RandomSource + ?Sized)) -> Self {
Self(T::random(source))
}
}

// FIXME the correct implementation is not clear. Waiting for a real world use case at https://github.com/rust-lang/libs-team/issues/230
//
// #[allow(unused_macros)]
Expand Down
8 changes: 8 additions & 0 deletions library/core/src/num/wrapping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use crate::ops::{
Add, AddAssign, BitAnd, BitAndAssign, BitOr, BitOrAssign, BitXor, BitXorAssign, Div, DivAssign,
Mul, MulAssign, Neg, Not, Rem, RemAssign, Shl, ShlAssign, Shr, ShrAssign, Sub, SubAssign,
};
use crate::random::{Random, RandomSource};

/// Provides intentionally-wrapped arithmetic on `T`.
///
Expand Down Expand Up @@ -84,6 +85,13 @@ impl<T: fmt::UpperHex> fmt::UpperHex for Wrapping<T> {
}
}

#[unstable(feature = "random", issue = "130703")]
impl<T: Random> Random for Wrapping<T> {
fn random(source: &mut (impl RandomSource + ?Sized)) -> Self {
Self(T::random(source))
}
}

#[allow(unused_macros)]
macro_rules! sh_impl_signed {
($t:ident, $f:ident) => {
Expand Down
Loading