- Notifications
You must be signed in to change notification settings - Fork 13.8k
Ergonomic ref counting #134797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ergonomic ref counting #134797
Conversation
e4e8ad3
to b003b20
Compare This comment has been minimized.
This comment has been minimized.
b003b20
to 94d4dde
Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
42e6956
to 0aaedb8
Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f9a2abe
to 0c29a0b
Compare This comment has been minimized.
This comment has been minimized.
0c29a0b
to b82e779
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close! First round of feedback.
I've pushed some tests and I've found some parsing errors, a diagnostic ICE and another issue that needs handling during borrowck. CI is going to be red but is fine as this is not yet done. |
This comment has been minimized.
This comment has been minimized.
2737662
to a5cb5f9
Compare Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in cc @BoxyUwU Some changes occurred in match checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
@nikomatsakis I'm going to do some further reviews, probably add some more tests, add comments, etc, etc but would leave this up for review as it is "almost" done. |
This comment has been minimized.
This comment has been minimized.
28beb7c
to d7104dc
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over the UseCloned
trait definition to double check the stability attributes -- seems good. Maybe add this slight modification to the test.
@bors r=nikomatsakis |
This is an experimental first version of ergonomic ref counting.
This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.
RFC: rust-lang/rfcs#3680
Tracking issue: #132290
Project goal: rust-lang/rust-project-goals#107
r? @nikomatsakis