Share the naked asm impl between cg_ssa and cg_clif #134232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| cc @folkertdev |
| r? @chenyukang rustbot has assigned @chenyukang. Use |
rustbot added S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
bjorn3 force-pushed the naked_asm_improvements branch 2 times, most recently from b8677a2 to d6b3c06 Compare This comment has been minimized.
This comment has been minimized.
bjorn3 force-pushed the naked_asm_improvements branch from d6b3c06 to 0dd4292 Compare | Some changes occurred in compiler/rustc_codegen_gcc |
bjorn3 added A-inline-assembly 
folkertdev reviewed Dec 13, 2024
folkertdev reviewed Dec 13, 2024
| ☔ The latest upstream changes (presumably #134381) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3 force-pushed the naked_asm_improvements branch from 42ae211 to 1358f53 Compare bjorn3 force-pushed the naked_asm_improvements branch from 1358f53 to dcf8b87 Compare 
| r? compiler |
| ☔ The latest upstream changes (presumably #135959) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3 force-pushed the naked_asm_improvements branch from dcf8b87 to 0b43964 Compare | ☔ The latest upstream changes (presumably #136332) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3 force-pushed the naked_asm_improvements branch from 0b43964 to b250776 Compare | ☔ The latest upstream changes (presumably #137163) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3 force-pushed the naked_asm_improvements branch from b250776 to 1341f83 Compare bjorn3 force-pushed the naked_asm_improvements branch from ef86f9d to 3066da8 Compare | Some changes occurred in compiler/rustc_codegen_ssa |
wesleywiser approved these changes Apr 29, 2025
| @bors r+ |
bors added S-waiting-on-bors tgross35 added a commit to tgross35/rust that referenced this pull request Apr 29, 2025
…esleywiser Share the naked asm impl between cg_ssa and cg_clif This was introduced in rust-lang#128004.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#134232 (Share the naked asm impl between cg_ssa and cg_clif) - rust-lang#140312 (Improve pretty-printing of braces) - rust-lang#140437 (enable msa feature for mips in codegen tests) - rust-lang#140438 (Add `rust.debug-assertions-tools` option) - rust-lang#140439 (miri: algebraic intrinsics: bring back float non-determinism) - rust-lang#140445 (Treat ManuallyDrop as ~const Destruct) - rust-lang#140446 (chore: fix some tests) - rust-lang#140448 (Rename `rustc_query_append!` to `rustc_with_all_queries!`) r? `@ghost` `@rustbot` modify labels: rollup
| @bors r- Seems to have failed in #140475 (comment) |
bors added S-waiting-on-author 
| @bors try |
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
Share the naked asm impl between cg_ssa and cg_clif This was introduced in rust-lang#128004. try-job: x86_64-apple-1
| ☀️ Try build successful - checks-actions |
| @bors r=wesleywiser Just a minor cg_clif change since the last approval. |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#134232 (Share the naked asm impl between cg_ssa and cg_clif) - rust-lang#139624 (Don't allow flattened format_args in const.) - rust-lang#140090 (Check bare function idents for non snake-case name) - rust-lang#140203 (Issue an error when using `no_mangle` on language items) - rust-lang#140450 (ast: Remove token visiting from AST visitor) - rust-lang#140498 (Misc tweaks to HIR typeck (mostly w.r.t. checking calls)) - rust-lang#140504 (transmutability: ensure_sufficient_stack when answering query) - rust-lang#140506 (unstable-book: fix capitalization) - rust-lang#140516 (Replace use of rustc_type_ir by rustc_middle) Failed merges: - rust-lang#140374 (Resolve instance for SymFn in global/naked asm) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
Rollup merge of rust-lang#134232 - bjorn3:naked_asm_improvements, r=wesleywiser Share the naked asm impl between cg_ssa and cg_clif This was introduced in rust-lang#128004.
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request May 14, 2025
…esleywiser Share the naked asm impl between cg_ssa and cg_clif This was introduced in rust-lang#128004.
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request May 25, 2025
…esleywiser Share the naked asm impl between cg_ssa and cg_clif This was introduced in rust-lang#128004.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was introduced in #128004.