Remove TokenKind::InvalidPrefix #133201
Merged
Remove TokenKind::InvalidPrefix #133201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Rename it as `invalid_ident_or_prefix`, which matches the possible outputs (`InvalidIdent` or `InvalidPrefix`). - Use the local wrapper for `is_xid_continue`, for consistency. - Make it clear what `\u{200d}` means. - Improve wording. - Use backticks consistently for examples.
It was added in rust-lang#123752 to handle some cases involving emoji, but it isn't necessary because it's always treated the same as `TokenKind::InvalidIdent`. This commit removes it, which makes things a little simpler.
rustbot added S-waiting-on-review 
| rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
compiler-errors approved these changes Nov 19, 2024
| r? compiler-errors @bors r+ rollup |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123947 (Add vec_deque::Iter::as_slices and friends) - rust-lang#125405 (Add std::thread::add_spawn_hook.) - rust-lang#133175 (ci: use free runner in dist-i686-msvc) - rust-lang#133183 (Mention std::fs::remove_dir_all in std::fs::remove_dir) - rust-lang#133188 (Add `visit` methods to ast nodes that already have `walk`s on ast visitors) - rust-lang#133201 (Remove `TokenKind::InvalidPrefix`) - rust-lang#133207 (Default-enable `llvm_tools_enabled` when no `config.toml` is present) - rust-lang#133213 (Correct the tier listing of `wasm32-wasip2`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
Rollup merge of rust-lang#133201 - nnethercote:rm-TokenKind-InvalidPrefix, r=compiler-errors Remove `TokenKind::InvalidPrefix` It's not needed. Best reviewed one commit at a time. r? `@estebank`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's not needed. Best reviewed one commit at a time.
r? @estebank