Skip to content

Unify FnKind between AST visitors and make WalkItemKind more straight forward #132787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 3 commits into from
Nov 17, 2024
Merged

Unify FnKind between AST visitors and make WalkItemKind more straight forward #132787

bors merged 3 commits into from
Nov 17, 2024

Conversation

@maxcabrajac
Copy link
Contributor

@maxcabrajac maxcabrajac commented Nov 8, 2024 •
edited
Loading

Unifying FnKind requires a bunch of changes to WalkItemKind::walk signature so I'll change them in one go

related to #128974 & #127615

r? @petrochenkov
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2024
@maxcabrajac
Copy link
Contributor Author

maxcabrajac commented Nov 8, 2024

@rustbot author
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@maxcabrajac maxcabrajac changed the title Unify FnCtxt between MutVisitor and Visitor Unify FnCtxt between AST visitors and make WalkItemKind more straight forward Nov 8, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@maxcabrajac maxcabrajac force-pushed the fnctxt branch 2 times, most recently from 36ec739 to ae95cf0 Compare November 12, 2024 16:21
@maxcabrajac maxcabrajac marked this pull request as ready for review November 12, 2024 17:53
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt
@maxcabrajac
Copy link
Contributor Author

maxcabrajac commented Nov 12, 2024

@rustbot review
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2024
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 15, 2024

r=me after squashing commits.
@rustbot author
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2024
@maxcabrajac
Copy link
Contributor Author

maxcabrajac commented Nov 15, 2024 •
edited
Loading

@bors r=petrochenkov

Is this it? I had to look around in other merged PRs

edit: Seems like its not =/
@bors
Copy link
Collaborator

bors commented Nov 15, 2024

@maxcabrajac: 🔑 Insufficient privileges: Not in reviewers
@maxcabrajac
Copy link
Contributor Author

maxcabrajac commented Nov 15, 2024

@rustbot review
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2024
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 16, 2024

Is this it? I had to look around in other merged PRs

It's it, it just needs someone with approval permissions.

@bors r+
@bors
Copy link
Collaborator

bors commented Nov 16, 2024

📌 Commit 516a3b0 has been approved by petrochenkov

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2024
@maxcabrajac maxcabrajac changed the title Unify FnCtxt between AST visitors and make WalkItemKind more straight forward Unify FnKind between AST visitors and make WalkItemKind more straight forward Nov 16, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024
@bors
Auto merge of rust-lang#133120 - matthiaskrgr:rollup-4actosy, r=matth…
d924044 
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131717 (Stabilize `const_atomic_from_ptr`) - rust-lang#132134 (Remove `ResultsVisitable`) - rust-lang#132449 (mark is_val_statically_known intrinsic as stably const-callable) - rust-lang#132569 (rustdoc search: allow queries to end in an empty path segment) - rust-lang#132787 (Unify FnKind between AST visitors and make WalkItemKind more straight forward) - rust-lang#132832 (Deny capturing late-bound ty/const params in nested opaques) - rust-lang#133097 (Opt out TaKO8Ki from review rotation for now) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024
@bors
Auto merge of rust-lang#133120 - matthiaskrgr:rollup-4actosy, r=matth…
1e0df74 
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131717 (Stabilize `const_atomic_from_ptr`) - rust-lang#132134 (Remove `ResultsVisitable`) - rust-lang#132449 (mark is_val_statically_known intrinsic as stably const-callable) - rust-lang#132569 (rustdoc search: allow queries to end in an empty path segment) - rust-lang#132787 (Unify FnKind between AST visitors and make WalkItemKind more straight forward) - rust-lang#132832 (Deny capturing late-bound ty/const params in nested opaques) - rust-lang#133097 (Opt out TaKO8Ki from review rotation for now) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 6b47c6d into rust-lang:master Nov 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024
@rust-timer
Unrolled build for rust-lang#132787
02fe7b2 
Rollup merge of rust-lang#132787 - maxcabrajac:fnctxt, r=petrochenkov Unify FnKind between AST visitors and make WalkItemKind more straight forward Unifying `FnKind` requires a bunch of changes to `WalkItemKind::walk` signature so I'll change them in one go related to rust-lang#128974 r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants

@maxcabrajac @rust-log-analyzer @rustbot @petrochenkov @bors