allow type-based search on foreign functions #132123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| rustbot has assigned @GuillaumeGomez. Use |
rustbot added S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
lolbinarycat force-pushed the rustdoc-search-foreign-func branch from 89bbecd to 20b0345 Compare This comment has been minimized.
This comment has been minimized.
lolbinarycat force-pushed the rustdoc-search-foreign-func branch from 20b0345 to d62cbaa Compare This comment has been minimized.
This comment has been minimized.
lolbinarycat force-pushed the rustdoc-search-foreign-func branch 3 times, most recently from 6c7720c to acc8555 Compare lolbinarycat force-pushed the rustdoc-search-foreign-func branch from acc8555 to 09773b4 Compare 
| Ha, yeah, type-based search should definitely include FFI functions. Thanks! r? notriddle @bors r+ rollup |
bors added S-waiting-on-bors workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 27, 2024
…n-func, r=notriddle allow type-based search on foreign functions fixes rust-lang#131804 preferably will be merged after rust-lang#129708, but that may take a while to be approved due to being a new feature, whereas this is definitely a bug, and should be fixed.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#132123 (allow type-based search on foreign functions) - rust-lang#132170 (Add a Few Codegen Tests) - rust-lang#132183 (Fix code HTML items making big blocks if too long) - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata) - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#132123 (allow type-based search on foreign functions) - rust-lang#132183 (Fix code HTML items making big blocks if too long) - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata) - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
Rollup merge of rust-lang#132123 - lolbinarycat:rustdoc-search-foreign-func, r=notriddle allow type-based search on foreign functions fixes rust-lang#131804 preferably will be merged after rust-lang#129708, but that may take a while to be approved due to being a new feature, whereas this is definitely a bug, and should be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #131804
preferably will be merged after #129708, but that may take a while to be approved due to being a new feature, whereas this is definitely a bug, and should be fixed.