compiletest: Extract auxiliary-crate properties to their own module/struct #131541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was previously only including ordinary `aux-build` crates, and not files associated with the other three kinds of auxiliary crate.
Collaborator
| rustbot has assigned @Mark-Simulacrum. Use |
rustbot added A-testsuite Collaborator
| Some changes occurred in src/tools/compiletest cc @jieyouxu |
jieyouxu approved these changes Oct 11, 2024
Member
jieyouxu left a comment
jieyouxu left a comment There was a problem hiding this comment.
Thanks, I would like to redo some of this handling because it's kinda insane to maintain, but in the short term this is a good improvement 👍 You can r=me once PR CI is green.
Member Author
| CI is green. @bors r=jieyouxu rollup=always |
Collaborator
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#129079 (Create `_imp__` symbols also when doing ThinLTO) - rust-lang#131208 (ABI: Pass aggregates by value on AIX) - rust-lang#131394 (fix(rustdoc): add space between struct fields and their descriptions) - rust-lang#131519 (Use Default visibility for rustc-generated C symbol declarations) - rust-lang#131541 (compiletest: Extract auxiliary-crate properties to their own module/struct) - rust-lang#131542 (next-solver: remove outdated FIXMEs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
Rollup merge of rust-lang#131541 - Zalathar:aux-props, r=jieyouxu compiletest: Extract auxiliary-crate properties to their own module/struct This moves the values of the 4 different `aux-*` directives into their own sub-struct. That struct, along with its directive-parsing code, can then be shared by both `TestProps` and `EarlyProps`. The final patch also fixes an oversight in up-to-date checking, by including *all* auxiliary crates in the timestamp, not just ordinary `aux-build` ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This moves the values of the 4 different
aux-*directives into their own sub-struct. That struct, along with its directive-parsing code, can then be shared by bothTestPropsandEarlyProps.The final patch also fixes an oversight in up-to-date checking, by including all auxiliary crates in the timestamp, not just ordinary
aux-buildones.