interpret: remove outdated FIXME #130690
Merged
interpret: remove outdated FIXME #130690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| rustbot has assigned @petrochenkov. Use |
rustbot added S-waiting-on-review Collaborator
| Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
Member
| @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 22, 2024
…e, r=jieyouxu interpret: remove outdated FIXME The rule about `repr(C)` types with compatible fields got removed from the ABI compat docs before they landed, so this FIXME here is no longer correct. (So this is basically a follow-up to rust-lang#130185, doing some more cleanup around deciding not to guarantee ABI compatibility for structurally compatible `repr(C)` types.)
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#129545 (rustdoc: redesign toolbar and disclosure widgets) - rust-lang#130658 (Fix docs of compare_bytes) - rust-lang#130670 (delay uncapping the max_read_size in File::read_to_end) - rust-lang#130680 (Call module_name_to_str instead of just unwrapping) - rust-lang#130690 (interpret: remove outdated FIXME) r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 22, 2024
…e, r=jieyouxu interpret: remove outdated FIXME The rule about `repr(C)` types with compatible fields got removed from the ABI compat docs before they landed, so this FIXME here is no longer correct. (So this is basically a follow-up to rust-lang#130185, doing some more cleanup around deciding not to guarantee ABI compatibility for structurally compatible `repr(C)` types.)
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#129545 (rustdoc: redesign toolbar and disclosure widgets) - rust-lang#130658 (Fix docs of compare_bytes) - rust-lang#130670 (delay uncapping the max_read_size in File::read_to_end) - rust-lang#130690 (interpret: remove outdated FIXME) - rust-lang#130692 (make unstable Result::flatten a const fn) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#130658 (Fix docs of compare_bytes) - rust-lang#130670 (delay uncapping the max_read_size in File::read_to_end) - rust-lang#130690 (interpret: remove outdated FIXME) - rust-lang#130692 (make unstable Result::flatten a const fn) - rust-lang#130702 (Add some missing unstable book tracking issue links) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
Rollup merge of rust-lang#130690 - RalfJung:interpret-abi-compat-fixme, r=jieyouxu interpret: remove outdated FIXME The rule about `repr(C)` types with compatible fields got removed from the ABI compat docs before they landed, so this FIXME here is no longer correct. (So this is basically a follow-up to rust-lang#130185, doing some more cleanup around deciding not to guarantee ABI compatibility for structurally compatible `repr(C)` types.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The rule about
repr(C)types with compatible fields got removed from the ABI compat docs before they landed, so this FIXME here is no longer correct. (So this is basically a follow-up to #130185, doing some more cleanup around deciding not to guarantee ABI compatibility for structurally compatiblerepr(C)types.)