Skip to content

Fixup Apple target's description strings #130650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fixup Apple target's description strings #130650

merged 1 commit into from
Sep 22, 2024

Conversation

BlackHoleFox
Copy link
Contributor

@BlackHoleFox BlackHoleFox commented Sep 21, 2024 •
edited
Loading

Noticed this inconsistency in how the Apple target's had their new descriptions written while looking at #130614, and figured it was easy enough to fixup shortly. I think prefixing every OS with Apple is clearer, especially for less known ones like visionOS and watchOS; so that's what was done here along with making the architecture names more consistent and then some other small tweaks.

r​? @thomcc

cc @madsmtm
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024
jieyouxu
jieyouxu approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems nice for consistency, I'll delegate the approval to @madsmtm, so please r=me if the renames make sense to you @madsmtm :)
@jieyouxu jieyouxu assigned jieyouxu and unassigned cjgillot Sep 21, 2024
@jieyouxu

This comment was marked as outdated.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@jieyouxu
Copy link
Member

@bors rollup
@jieyouxu
Copy link
Member

@bors delegate=@madsmtm
@bors
Copy link
Collaborator

bors commented Sep 21, 2024

✌️ @madsmtm, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu
@jieyouxu jieyouxu added the O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) label Sep 21, 2024
taiki-e
taiki-e reviewed Sep 21, 2024
View reviewed changes
madsmtm
madsmtm reviewed Sep 21, 2024
View reviewed changes
Copy link
Contributor

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have much opinion on this, looks good other than the Mac Catalyst thing noted
@BlackHoleFox BlackHoleFox force-pushed the apple-target-desc-consistency branch from d40f412 to 114093c Compare September 21, 2024 16:00
@jieyouxu
Copy link
Member

Thanks!
@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Sep 22, 2024

📌 Commit 114093c has been approved by jieyouxu

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2024
@workingjubilee workingjubilee mentioned this pull request Sep 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
@bors
Auto merge of rust-lang#130688 - workingjubilee:rollup-ovre6p7, r=wor…
80aa6fa 
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#130648 (move enzyme flags from general cargo to rustc-specific cargo) - rust-lang#130650 (Fixup Apple target's description strings) - rust-lang#130664 (Generate line numbers for non-rust code examples as well) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130669 (tests: Test that `extern "C" fn` ptrs lint on slices) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 2875d6f into rust-lang:master Sep 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
@rust-timer
Unrolled build for rust-lang#130650
1b94e68 
Rollup merge of rust-lang#130650 - BlackHoleFox:apple-target-desc-consistency, r=jieyouxu Fixup Apple target's description strings Noticed this inconsistency in how the Apple target's had their new descriptions written while looking at rust-lang#130614, and figured it was easy enough to fixup shortly. I think prefixing every OS with `Apple` is clearer, especially for less known ones like `visionOS` and `watchOS`; so that's what was done here along with making the architecture names more consistent and then some other small tweaks. ~~r​? `@thomcc~~` cc `@madsmtm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

7 participants

@BlackHoleFox @rustbot @jieyouxu @bors @madsmtm @taiki-e @cjgillot