Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we retain an example of what makes something "uninhabited" in this case, or a link to documentation that describes the notion of something being uninhabited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled a bit with what to say here and would welcome suggestions.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick grep indicates this is the first time we're using the word in the standard library documentation. But the reference: https://github.com/rust-lang/reference/blob/master/src/glossary.md?plain=1#L284-L289 and the dev guide: https://github.com/rust-lang/rustc-dev-guide/blob/master/src/appendix/glossary.md?plain=1#L93 both provide a definition.
If we need to put a definition in the standard library docs I'm not sure where it would go, but I'd be happy pasting either of these in. Or just directing people to the reference, though that sounds bit-rotty unless we have something that checks that a link to that specific glossary entry still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I don't think (un)inhabited types should be special-cased here, I have chosen an entirely different wording now.