Prereq5 for async drop - AsyncDropGlue & FutureDropPoll instances preparation #129740
Conversation
rustbot added S-waiting-on-review 
| Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras |
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from 6f6d305 to 8dd8360 Compare azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from 8dd8360 to 379555a Compare 
This comment has been minimized.
This comment has been minimized.
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from 379555a to 175820b Compare 
| ☔ The latest upstream changes (presumably #129313) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from 175820b to 62d37f8 Compare | ☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
| r? @nikomatsakis is going to look into this |
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from 62d37f8 to e439b5d Compare This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch 2 times, most recently from 7356155 to dfc9b26 Compare | ☔ The latest upstream changes (presumably #136943) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from dfc9b26 to 5bf0da9 Compare | ☔ The latest upstream changes (presumably #139354) made this pull request unmergeable. Please resolve the merge conflicts. |
…p from previous async drop glue implementation
azhogin force-pushed the azhogin/async-drop-prereq5-instances-preparation branch from 5bf0da9 to 9a0fb73 Compare | ☔ The latest upstream changes (presumably #139578) made this pull request unmergeable. Please resolve the merge conflicts. |
8 participants
This is subpart 5 PR of #123948, just for review purposes.
AsyncDropGlueinstance forasync_drop_in_place<T>(...)::{{closure0}}shim generation for not coroutine type.FutureDropPollinstance forasync_drop_in_place<T>(...)::{{closure0}}shim generation for coroutine type.Those have different behaviour, because for normal type we are generating normal (sync) drop glue generation using drop elaboration and then StateTransform pass for transformation into coroutine (later commits). And for coroutine we need to poll this coroutine async drop poll function with the same coroutine layout.
Review only last commit, based on previous PR #129739