Make tidy fast without compromising case alternation #127457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added A-testsuite 
This comment has been minimized.
This comment has been minimized.
Noratrieb reviewed Jul 7, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #127455) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
| it can take a few days or weeks for the reviewer to get back to you, that's normal. we usually recommend pinging after two weeks of inactivity. |
klensy reviewed Jul 9, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| Thanks for the PR! |
bors added S-waiting-on-bors 
| Please no 14 commits :-( |
| @bors r- |
bors added S-waiting-on-author 
| @rustbot review |
rustbot added S-waiting-on-review 
| Thanks for the squash! |
bors added S-waiting-on-bors
Sure! I'm editing on mobile, that's why the many formatting commits and tiny fixes... Sorry for that. |
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#126152 (size_of_val_raw: for length 0 this is safe to call) - rust-lang#127252 (Add edge-case examples to `{count,leading,trailing}_{ones,zeros}` methods) - rust-lang#127374 (Tweak "wrong # of generics" suggestions) - rust-lang#127457 (Make tidy fast without compromising case alternation) - rust-lang#127480 (Fix build failure on vxworks rust-lang#127084 ) - rust-lang#127733 (Replace some `mem::forget`'s with `ManuallyDrop`) - rust-lang#128120 (Gate `AsyncFn*` under `async_closure` feature) - rust-lang#128131 (Import `c_void` rather than using the full path) - rust-lang#128133 (Improve spans on evaluated `cfg_attr`s.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2024
Rollup merge of rust-lang#127457 - donno2048:master, r=albertlarsan68 Make tidy fast without compromising case alternation Fixes tidy speed issue but still catches case-alternation, enabled for other `style.rs` files, and also detects test files better. r? `@albertlarsan68` `@Nilstrieb`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes tidy speed issue but still catches case-alternation, enabled for other
style.rsfiles, and also detects test files better.r? @albertlarsan68
@Nilstrieb