Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• Implement new effects desugaring #120639 (Implement new effects desugaring)
• patchable-function-entry: Add unstable compiler flag and attribute #124741 (patchable-function-entry: Add unstable compiler flag and attribute)
• make cargo submodule optional #126470 (make cargo submodule optional)
• ignore llvm::Lld if lld is not enabled #126701 (ignore llvm::Lld if lld is not enabled)
• core: avoid extern types in formatting infrastructure #126956 (core: avoid extern types in formatting infrastructure)
• Simplify str::clone_into #126970 (Simplify str::clone_into)
• Tighten fn_decl_span for async blocks #127058 (Tighten fn_decl_span for async blocks)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=7

[bors]

📌 Commit 7d05157 has been approved by matthiaskrgr

It is now in the queue for this repository.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 Running tests/compile-test.rs (obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/compile_test-e2f2ae96a28c6a7b) FAILED TEST: tests/ui/missing_const_for_fn/could_be_const.rs command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_config=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_config-17fa9f95c9b8f88f.rlib" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-5fa9affb7f4804a2.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-5726c12621123bb4.rlib" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-c05264ebc02d0b99.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-ae846d6788d6a9f1.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-e9aa61e1e4ee057e.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-8dba92144dd323d0.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-0383f3501f3470c2.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-caed1d72b1950c44.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-5c59675e11f6188b.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-2233436f0b800125.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-b8ecf01f7994beb1.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-d534f89567b59ccc.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/tests/ui/missing_const_for_fn" "tests/ui/missing_const_for_fn/could_be_const.rs" "--edition" "2021" error: actual output differed from expected Execute `cargo uibless` to update `tests/ui/missing_const_for_fn/could_be_const.stderr` to the actual output --- tests/ui/missing_const_for_fn/could_be_const.stderr +++ <stderr output> +++ <stderr output> error: this could be a `const fn` --> tests/ui/missing_const_for_fn/could_be_const.rs:14:5 ... 159 lines skipped ... LL | fn d(this: D) {} + | +help: make the function `const` + | + | +LL | const fn d(this: D) {} + | +++++ error: this could be a `const fn` ... 82 lines skipped ... error: aborting due to 18 previous errors --- error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:20:5 | LL | / fn const_generic_params<'a, T, const N: usize>(&self, b: &'a [T; N]) -> &'a [T; N] { LL | | b LL | | } | |_____^ | | help: make the function `const` | LL | const fn const_generic_params<'a, T, const N: usize>(&self, b: &'a [T; N]) -> &'a [T; N] { error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:27:1 | --- error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:33:1 | LL | / fn two() -> i32 { LL | | let abc = 2; LL | | abc LL | | } | |_^ | |_^ | help: make the function `const` | LL | const fn two() -> i32 { | +++++ error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:40:1 | LL | / fn string() -> String { --- error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:46:1 | LL | / unsafe fn four() -> i32 { LL | | 4 LL | | } | |_^ | --- error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:61:1 | LL | / fn generic_arr<T: Copy>(t: [T; 1]) -> T { LL | | t[0] LL | | } | |_^ | | help: make the function `const` | LL | const fn generic_arr<T: Copy>(t: [T; 1]) -> T { | +++++ error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:75:9 | | LL | / pub fn b(self, a: &A) -> B { LL | | B LL | | } | |_________^ | | help: make the function `const` | LL | pub const fn b(self, a: &A) -> B { error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:85:5 | | LL | / fn const_fn_stabilized_before_msrv(byte: u8) { LL | | LL | | byte.is_ascii_digit(); | |_____^ | help: make the function `const` | | LL | const fn const_fn_stabilized_before_msrv(byte: u8) { error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:97:1 | | LL | / fn msrv_1_46() -> i32 { LL | | 46 LL | | } | |_^ | | help: make the function `const` | LL | const fn msrv_1_46() -> i32 { | +++++ error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:117:1 | | LL | fn d(this: D) {} | help: make the function `const` | | LL | const fn d(this: D) {} | +++++ error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:125:9 | LL | / fn deref_ptr_can_be_const(self) -> usize { LL | / fn deref_ptr_can_be_const(self) -> usize { LL | | LL | | unsafe { *self.0 as usize } | |_________^ | help: make the function `const` | --- ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:141:5 | LL | / fn union_access_can_be_const() { LL | | LL | | let bar = Bar { val: 1 }; LL | | let _ = unsafe { bar.val }; | |_____^ | help: make the function `const` | | LL | const fn union_access_can_be_const() { | +++++ error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:155:9 | LL | / pub fn new(strings: Vec<String>) -> Self { LL | | Self { strings } | |_________^ | help: make the function `const` | | LL | pub const fn new(strings: Vec<String>) -> Self { error: this could be a `const fn` ##[error] --> tests/ui/missing_const_for_fn/could_be_const.rs:160:9 | | LL | / pub fn empty() -> Self { LL | | Self { strings: Vec::new() } | |_________^ | help: make the function `const` |