add needs-unwind to UI test #126740
Merged
add needs-unwind to UI test #126740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the `tail-expr-lock-poisoning` UI test uses the `panic::catch_unwind` API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the `needs-unwind` attribute to signal this
Collaborator
rustbot added S-waiting-on-review 
Contributor
| @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors 
bjorn3 reviewed Jun 20, 2024
| //@ [edition2024] compile-flags: -Zunstable-options | ||
| //@ [edition2024] edition: 2024 | ||
| //@ run-pass | ||
| //@ needs-unwind |
Member
There was a problem hiding this comment.
I think you can remove the //@ ignore-wasm that test directive is only used here due to wasm not supporting panic=unwind.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126735 (collect attrs in const block expr) - rust-lang#126737 (Remove `feature(const_closures)` from libcore) - rust-lang#126740 (add `needs-unwind` to UI test) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2024
Rollup merge of rust-lang#126740 - ferrocene:ja-ui-test-needs-unwind, r=lcnr add `needs-unwind` to UI test the `tail-expr-lock-poisoning` UI test uses the `panic::catch_unwind` API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the `needs-unwind` attribute to signal this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the
tail-expr-lock-poisoningUI test uses thepanic::catch_unwindAPI so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add theneeds-unwindattribute to signal this