Migrate run-make/no-intermediate-extras to new rmake.rs #125218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added A-testsuite | Some changes occurred in run-make tests. cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jieyouxu reviewed May 17, 2024
Comment on lines 13 to 21
| match fs::remove_file(tmp_dir().join("foo.bc")) { | ||
| Ok(_) => { | ||
| println!("An unwanted .bc file was created by run-make/no-intermediate-extras."); | ||
| std::process::exit(1); | ||
| } | ||
| Err(e) => { | ||
| std::process::exit(0); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this could probably be simplified to
assert!( fs::remove_file(tmp_dir().join("foo.bc")).is_err(), "An unwanted .bc file was created by run-make/no-intermediate-extras." );
| Thanks! @bors r+ rollup |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#124570 (Miscellaneous cleanups) - rust-lang#124772 (Refactor documentation for Apple targets) - rust-lang#125011 (Add opt-for-size core lib feature flag) - rust-lang#125218 (Migrate `run-make/no-intermediate-extras` to new `rmake.rs`) - rust-lang#125225 (Use functions from `crt_externs.h` on iOS/tvOS/watchOS/visionOS) - rust-lang#125266 (compiler: add simd_ctpop intrinsic) - rust-lang#125348 (Small fixes to `std::path::absolute` docs) Failed merges: - rust-lang#125296 (Fix `unexpected_cfgs` lint on std) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
Rollup merge of rust-lang#125218 - Oneirical:easy-test-the-third, r=jieyouxu Migrate `run-make/no-intermediate-extras` to new `rmake.rs` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part of #121876 and the associated Google Summer of Code project.