proposal to support raw_attribute with raw pointer

[cre4ture]

Hello rust community,

I'm still rather new to rust, but I collected experience with rust in the uutils project.
There I'm currently trying to make use of the conpty windows feature and stumbled across the same topic as discussion in #114854.

This was my solution to it and I found that its probably simpler as all other solutions I've seen on the discussion topic (#121951, #123604). And thus its easier to understand, use and therefor might take less discussions to get it approved.

The key element is, that I don't change the existing approach for normal data attributes with the Box::new(). I just extend the API with a second variant that takes raw pointers.

Just let me know what you think.
If there is positive feedback, I will adapt documentation and tests.

I also added a change (force_use_std_handles) that will be needed to have a proper support of the PSEUDOCONSOLE / conpty.
Its clear that this should be in a different PR. I will split it as needed after some feedback.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ChrisDenton (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[bors]

☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #130865) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase $ git pull --rebase https://github.com/rust-lang/rust.git master $ git push --force-with-lease 

The following commits are merge commits:

• d453e07

[Dylan-DPC]

@cre4ture any updates on the CI failure? thanks

[cre4ture]

@cre4ture any updates on the CI failure? thanks

@Dylan-DPC thanks for the trigger.
It was a small issue with the merge. It should be fixed now. Lets see what the CI says.
I was on vacation for 4 weeks and additionally I didn't expect much attention on this PR. That's the reason for the delay.

[bors]

☔ The latest upstream changes (presumably #134590) made this pull request unmergeable. Please resolve the merge conflicts.

[cre4ture]

Seems that merged PR #123604 makes this PR obsolete