Skip to content

Make type_ascribe! not a built-in #122806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

Make type_ascribe! not a built-in #122806

merged 1 commit into from
Mar 21, 2024
+28 −44

Conversation

compiler-errors
Copy link
Member

The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔

r? @fmease since you told me about builtin# lol
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 21, 2024
fmease
fmease approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong!
r=me with or without nits addressed at your convenience
@compiler-errors
Copy link
Member Author

@bors r=fmease rollup
@bors
Copy link
Collaborator

bors commented Mar 21, 2024

📌 Commit a015b90 has been approved by fmease

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2024
@fmease
Copy link
Member

fmease commented Mar 21, 2024 •
edited
Loading

The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔

Not worth it imo. Can be done at some other point once ppl using e.g. offset_of! complain about it.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#122806 - compiler-errors:type-ascribe, r=fm…
6fab36b 
…ease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? `@fmease` since you told me about builtin# lol
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 21, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 21, 2024
@workingjubilee
Rollup merge of rust-lang#122806 - compiler-errors:type-ascribe, r=fm…
b3869b6 
…ease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? ``@fmease`` since you told me about builtin# lol
@workingjubilee workingjubilee mentioned this pull request Mar 21, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2024
@bors
Auto merge of rust-lang#122816 - workingjubilee:rollup-2jipmky, r=wor…
ccb841f 
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122456 (CFI: Skip non-passed arguments) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122771 (add some comments to hir::ModuleItems) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#122806 - compiler-errors:type-ascribe, r=fm…
6d186e3 
…ease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? ```@fmease``` since you told me about builtin# lol
This was referenced Mar 21, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2024
@bors
Auto merge of rust-lang#122822 - matthiaskrgr:rollup-rjgmnbe, r=matth…
2627e9f 
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122358 (Don't ICE when encountering bound regions in generator interior type) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) Failed merges: - rust-lang#122771 (add some comments to hir::ModuleItems) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 62e414d into rust-lang:master Mar 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2024
@rust-timer
Unrolled build for rust-lang#122806
905a319 
Rollup merge of rust-lang#122806 - compiler-errors:type-ascribe, r=fmease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? ````@fmease```` since you told me about builtin# lol
@rustbot rustbot added this to the 1.79.0 milestone Mar 21, 2024
This was referenced May 2, 2024
Closed
Merged
fmease added a commit to fmease/rust that referenced this pull request May 3, 2024
@fmease
Rollup merge of rust-lang#124637 - fmease:ast-pretty-ty-asc-builtin-s…
b8a9e20 
…yn, r=compiler-errors AST pretty: Use `builtin_syntax` for type ascription Follow-up to rust-lang#122806. CC #124619.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#124637 - fmease:ast-pretty-ty-asc-builtin-s…
e6c82d9 
…yn, r=compiler-errors AST pretty: Use `builtin_syntax` for type ascription Follow-up to rust-lang#122806. CC #124619.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
@rust-timer
Unrolled build for rust-lang#124637
51be999 
Rollup merge of rust-lang#124637 - fmease:ast-pretty-ty-asc-builtin-syn, r=compiler-errors AST pretty: Use `builtin_syntax` for type ascription Follow-up to rust-lang#122806. CC #124619.
@est31 est31 mentioned this pull request Jul 12, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

4 participants

@compiler-errors @bors @fmease @rustbot