Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 9, 2024

Just two things I noticed while working on another PR.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2024

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 9, 2024
@jhpratt
Copy link
Member

jhpratt commented Mar 9, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 9, 2024

📌 Commit 1082c36 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2024
library/core: fix a comment, and a cfg(miri) warning Just two things I noticed while working on another PR.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#121567 (Avoid some interning in bootstrap) - rust-lang#121813 (Misc improvements to non local defs lint implementation) - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once) - rust-lang#121907 (skip sanity check for non-host targets in `check` builds) - rust-lang#122160 (Eagerly translate `HelpUseLatestEdition` in parser diagnostics) - rust-lang#122178 (ci: add a runner for vanilla LLVM 18) - rust-lang#122186 (Remove a workaround for a bug) - rust-lang#122187 (Move metadata header and version checks together) - rust-lang#122215 (Some tweaks to the parallel query cycle handler) - rust-lang#122223 (Fix typo in `VisitorResult`) - rust-lang#122232 (library/core: fix a comment, and a cfg(miri) warning) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#121358 (Reduce alignment of TypeId to u64 alignment) - rust-lang#121813 (Misc improvements to non local defs lint implementation) - rust-lang#122160 (Eagerly translate `HelpUseLatestEdition` in parser diagnostics) - rust-lang#122178 (ci: add a runner for vanilla LLVM 18) - rust-lang#122187 (Move metadata header and version checks together) - rust-lang#122209 (fix incorrect path resolution in tidy) - rust-lang#122215 (Some tweaks to the parallel query cycle handler) - rust-lang#122223 (Fix typo in `VisitorResult`) - rust-lang#122224 (Add missing regression tests) - rust-lang#122232 (library/core: fix a comment, and a cfg(miri) warning) - rust-lang#122233 (miri: do not apply aliasing restrictions to Box with custom allocator) - rust-lang#122237 (Remove `Ord` from `ClosureKind`) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 2bb4b99 into rust-lang:master Mar 9, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
Rollup merge of rust-lang#122232 - RalfJung:misc, r=jhpratt library/core: fix a comment, and a cfg(miri) warning Just two things I noticed while working on another PR.
@RalfJung RalfJung deleted the misc branch March 9, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

4 participants