Skip to content

Conversation

@beetrees
Copy link
Contributor

@beetrees beetrees commented Mar 8, 2024

LLVM 14 support was dropped in #114148, so this LLVM version check is no longer required.

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2024
@cuviper
Copy link
Member

cuviper commented Mar 8, 2024

Thanks!

r? cuviper
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 8, 2024

📌 Commit 0b6006e has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2024
@rustbot rustbot unassigned lcnr Mar 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121201 (align_offset, align_to: no longer allow implementations to spuriously fail to align) - rust-lang#122076 (Tweak the way we protect in-place function arguments in interpreters) - rust-lang#122100 (Better comment for implicit captures in RPITIT) - rust-lang#122157 (Add the new description field to Target::to_json, and add descriptions for some MSVC targets) - rust-lang#122164 (Fix misaligned loads when loading UEFI arg pointers) - rust-lang#122171 (Add some new solver tests) - rust-lang#122172 (Don't ICE if we collect no RPITITs unless there are no unification errors) - rust-lang#122197 (inspect formatter: add braces) - rust-lang#122198 (Remove handling for previously dropped LLVM version) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit b61edb9 into rust-lang:master Mar 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2024
Rollup merge of rust-lang#122198 - beetrees:no-llvm-14, r=cuviper Remove handling for previously dropped LLVM version LLVM 14 support was dropped in rust-lang#114148, so this LLVM version check is no longer required.
@rustbot rustbot added this to the 1.78.0 milestone Mar 8, 2024
@beetrees beetrees deleted the no-llvm-14 branch March 11, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants