Skip to content

style-guide: Note that we don't account for comments in every possible place #121762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

style-guide: Note that we don't account for comments in every possible place #121762

wants to merge 1 commit into from

Conversation

joshtriplett
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2024

r? @calebcartwright

rustbot has assigned @calebcartwright.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Feb 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2024

Some changes occurred in src/doc/style-guide

cc @rust-lang/style
@ChrisDenton
Copy link
Member

It may even result in the comment being deleted (or has that been fixed?)
@joshtriplett
Copy link
Member Author

@rfcbot merge

@rfcbot concern review-other-text-mentioning-comments
@rfcbot
Copy link

rfcbot commented Feb 28, 2024 •
edited by compiler-errors
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.
@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 28, 2024
@calebcartwright calebcartwright mentioned this pull request Mar 13, 2024
Merged
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
@alex-semenyuk alex-semenyuk added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2024
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2025
@Dylan-DPC
Copy link
Member

(this is waiting on a concern raised in the fcp to be addressed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-style Relevant to the style team, which will review and decide on the PR/issue.

7 participants

@joshtriplett @rustbot @ChrisDenton @rfcbot @Dylan-DPC @alex-semenyuk @calebcartwright