[DO NOT MERGE] Sync from ra experiment #117544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…garding invocation strategy and location
Tested for two cases: 1. Simple Use 2. Complex Use
fix typo in mbe/lib.rs comment fix typo in mbe/lib.rs comment
make mir::ProjectionStore-impls pub-accessible When using RA as a crate the `mir::Place` `projection` is accessible, however there is no way to translate the `ProjectionId` to a `&[PlaceElem]`, as the `ProjectionId::lookup` is private. Personally, I would only need the `ProjectionId::lookup`-fn to be `pub`, but I don't see any reason why the others should be kept private.. am I missing something `@HKalbasi` ? Relates to: rust-lang/rust-analyzer#15575
fix: make cursor select at _tmp Here make cursor select at `_tmp` atuomatically after the assist apply. Refer to [vscode snippet placeholder](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_placeholders).  following rust-lang/rust-analyzer#15752
fix: Fix metrics workflow to use deploy key I think this should be correct
Update rustc_abi dependency cc rust-lang#116269
Emacs 29 is now released, and include an example of enabling clippy.
Expand Emacs documentation Emacs 29 is now released, and include an example of enabling clippy.
internal: Create `~/.ssh` before writing deploy key
internal: Fix metrics repo url
…=Veykril String literals diagnose Continues the work from rust-lang#15744 to add diagnosis errors to Str, ByteStr, and CStr literal kinds. Also replaces `unescape_char` for `unescape_byte` to use the correct method for Byte literals.
rustbot added the S-waiting-on-review 
| Some changes occurred in src/tools/rust-analyzer cc @rust-lang/rust-analyzer |
rustbot added has-merge-commits | There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands: The following commits are merge commits:
|
This comment has been minimized.
This comment has been minimized.
| The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
34 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
r? @ghost