update Miri #114932
Merged
update Miri #114932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
llvm.prefetch is not a math function fixes the comment in src/shims/foreign_items.rs
Add checked float-to-int helper function As discussed in rust-lang/miri#2989 (comment)
Automatic sync from rustc
[nit][typo] Fix out of order words.
C `mem` function shims: consistently treat "invalid" pointers as UB Depends on rust-lang#113435.
Co-authored-by: Ralf Jung <post@ralfj.de>
It's similar to rust-lang/miri#3021 and should improve maintainability.
Automatic sync from rustc
…Jung Replace hand-written binary search with Vec::binary_search_by. It's similar to rust-lang/miri#3021 and should improve maintainability.
When reporting a heap use-after-free, say where the allocation was allocated and deallocated This is a partial solution to: rust-lang/miri#2917 Currently in the interpreter, we only have accurate information for where heap allocations are allocated and deallocated (see rust-lang/miri#2940 (comment)). So this just implements support for allocations where the information is already available, and the full support will require more interpreter tweaks.
on out-of-bounds error, show where the allocation was created This seems useful, I think? r? `@saethlin`
If `size > 0` current implementation will first create an empty vec and then push an element into it, which will cause a resize that can be easily avoided. It's obviously not a big deal, but this also gets rid of `mut` local variable.
Avoid unnecessary Vec resize. If `size > 0` current implementation will first create an empty vec and then push an element into it, which will cause a resize that can be easily avoided. It's obviously not a big deal, but this also gets rid of `mut` local variable.
rustbot added the S-waiting-on-review 
Collaborator
| The Miri subtree was changed cc @rust-lang/miri |
Member Author
| @bors r+ p=1 |
Collaborator
bors removed the S-waiting-on-review bors added the S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions |
Collaborator
| Finished benchmarking commit (4a0402c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.38s -> 635.726s (0.53%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
r? @ghost