DebugInfo: Updates test cases that add method declarations. #114760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We've investigated one reason why debugging information often goes wrong at https://reviews.llvm.org/D152095. > LLVM can't handle IR where subprogram definitions are nested within DICompositeType when doing LTO builds, > because there's no good way to cross the CU boundary to insert a nested DISubprogram definition in one CU into a type defined in another CU.
| (rustbot has picked a reviewer for you, use r? to override) |
rustbot added the S-waiting-on-review 
| r? @cuviper |
dianqk force-pushed the update-test-for-type-decl-disubprogram branch from d06ceec to 6f5b4e3 Compare 
| Thanks! @bors r+ rollup |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#114745 (Make Const more useful in smir) - rust-lang#114752 (fixed *const [type error] does not implement the Copy trait) - rust-lang#114760 (DebugInfo: Updates test cases that add method declarations.) - rust-lang#114815 (Update books) - rust-lang#114817 (Remove unnecessary FIXME) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We've investigated one reason why debugging information often goes wrong at https://reviews.llvm.org/D152095.
In #111167, we added a declaration for the DISubprogram for the method. This PR completes this test case.
stream history: https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/Dwarf.20CUs/near/384269475.