item_impl holds an Option<> to the trait ref, not a list of trait refs. ... #11415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Seems to need a rebase. You can iterate options just fine (just a 1 or 0 element iterator), but I like the variable rename. r=me with a rebase. |
…s. Therefore, we should not iterate over it.
| Rebased ^ |
bors added a commit that referenced this pull request Jan 11, 2014
...Therefore, we should not iterate over it.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 28, 2023
…pedantic, r=flip1995 Move `needless_raw_string_hashes` to `pedantic` IMO it doesn't improve code enough to be warn by default. [It seems to be unclear to some also](rust-lang/rust-clippy#11402), but that can probably be remedied separately changelog: Moved [`needless_raw_string_hashes`] to `pedantic` (Now allow-by-default) [rust-lang#11415](rust-lang/rust-clippy#11415) r? `@flip1995`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
...Therefore, we should not iterate over it.