Explicitly reject negative and reservation drop impls #110859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot added S-waiting-on-review 
| cc @rust-lang/types I guess, though this is already behind a feature gate ( |
| ☔ The latest upstream changes (presumably #110852) made this pull request unmergeable. Please resolve the merge conflicts. |
| This |
rust-cloud-vms bot force-pushed the no-negative-drop-impls branch 2 times, most recently from c27dbf6 to bd146c7 Compare 
| @bors r+ |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110859 (Explicitly reject negative and reservation drop impls) - rust-lang#111020 (Validate resolution for SelfCtor too.) - rust-lang#111024 (Use the full Fingerprint when stringifying Svh) - rust-lang#111027 (Remove `allow(rustc::potential_query_instability)` for `builtin_macros`) - rust-lang#111039 (Encode def span for foreign return-position `impl Trait` in trait) - rust-lang#111070 (Don't suffix `RibKind` variants) - rust-lang#111094 (Add needs-unwind annotations to tests that need stack unwinding) - rust-lang#111103 (correctly recurse when expanding anon consts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #110858
It doesn't really make sense for a type to have a
!Dropimpl. Or at least, I don't want us to implicitly assign a meaning to it by the way the compiler currently handles it (incompletely), and rather I would like to see a PR (or an RFC...) assign a meaning to!Dropif we actually wanted one for it.