Rollup of 4 pull requests #110445
Closed
Rollup of 4 pull requests #110445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I suspect this macro was around before `TypeFoldable`/`TypeVisitable` were derivable. But now it's only used for two types, `Result` and `Option`. Removing the macro and implementing the traits for those types by hand makes the code much simpler.
They both allow for a lifetime other than `'tcx`, but this isn't needed.
This avoids `rustc_data_structures` depending on `serde_json` which allows it to be compiled much earlier, unlocking most of rustc.
…ros, r=lcnr Clean up traversal macros The declarative macros relating to type folding and visiting can be simplified. r? `@lcnr`
…bject-notationing, r=fee1-dead Don't use `serde_json` to serialize a simple JSON object This avoids `rustc_data_structures` depending on `serde_json` which allows it to be compiled much earlier, unlocking most of rustc. This used to not matter, but after rust-lang#110407 we're not blocked on fluent anymore, which means that it's now a blocking edge.  This saves a few more seconds. cc `@Zoxc` who added it recently
…ram, r=petrochenkov Encode def span for `ConstParam` Fixes rust-lang#110206 r? `@petrochenkov`
…i-obk Check freeze with right param-env in `deduced_param_attrs` We're checking if a trait (`Freeze`) holds in a polymorphic function, but not using that function's own (reveal-all) param-env. This causes us to try to eagerly normalize a specializable projection type that has no default value, which causes an ICE. Fixes rust-lang#110171
rustbot added S-waiting-on-review | @bors r+ rollup=never p=4 |
bors added S-waiting-on-bors | ⌛ Testing commit c32ab1d with merge 4e24dfc69d18b2132ccfa2aaa8349ee1469881ec... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
serde_jsonto serialize a simple JSON object #110409 (Don't useserde_jsonto serialize a simple JSON object)ConstParam#110425 (Encode def span forConstParam)deduced_param_attrs#110434 (Check freeze with right param-env indeduced_param_attrs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup