Skip to content

Conversation

chenyukang
Copy link
Member

Follow up fix for #107590

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-log-analyzer

This comment has been minimized.

@chenyukang chenyukang force-pushed the yukang/fix-benchmarks branch from 276f61e to f3ff183 Compare February 21, 2023 02:57
@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@chenyukang chenyukang force-pushed the yukang/fix-benchmarks branch from f3ff183 to 62cfd8a Compare February 21, 2023 03:26
@the8472
Copy link
Member

the8472 commented Feb 21, 2023

Do you have before/after numbers to see if they have any effect? you can use cargo benchcmp to produce a diff of separate benchmark runs.

@chenyukang
Copy link
Member Author

Do you have before/after numbers to see if they have any effect? you can use cargo benchcmp to produce a diff of separate benchmark runs.

yes, it has effect, for example:

gh-chenyukang@dev-desktop-us-2:~/2rust$ cargo benchcmp i1.perf i2.perf name i1.perf ns/iter i2.perf ns/iter diff ns/iter diff % speedup num::dec2flt::bench_0 50 62 12 24.00% x 0.81 num::dec2flt::bench_1e150 51 61 10 19.61% x 0.84 num::dec2flt::bench_42 36 47 11 30.56% x 0.77 num::dec2flt::bench_huge_int 190 196 6 3.16% x 0.97 num::dec2flt::bench_long_decimal_and_exp 206 212 6 2.91% x 0.97 num::dec2flt::bench_max 74 84 10 13.51% x 0.88 num::dec2flt::bench_min_normal 75 85 10 13.33% x 0.88 num::dec2flt::bench_min_subnormal 52 61 9 17.31% x 0.85 num::dec2flt::bench_pi_long 168 172 4 2.38% x 0.98 num::dec2flt::bench_pi_short 62 77 15 24.19% x 0.81 num::dec2flt::bench_short_decimal 56 71 15 26.79% x 0.79 num::flt2dec::bench_big_shortest 213 213 0 0.00% x 1.00 num::flt2dec::bench_small_shortest 152 153 1 0.66% x 0.99
@chenyukang
Copy link
Member Author

r? library

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2023

Failed to set assignee to library: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@chenyukang
Copy link
Member Author

r? libs

@rustbot rustbot assigned joshtriplett and unassigned scottmcm Apr 29, 2023
@workingjubilee
Copy link
Member

This looks much better, thank you!

r? @workingjubilee
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented May 15, 2023

📌 Commit 62cfd8a has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108291 (Fix more benchmark test with black_box) - rust-lang#108356 (improve doc test for UnsafeCell::raw_get) - rust-lang#110049 (Don't claim `LocalKey::with` prevents a reference to be sent across threads) - rust-lang#111525 (Stop checking for the absence of something that doesn't exist) - rust-lang#111538 (Make sure the build.rustc version is either the same or 1 apart) - rust-lang#111578 (Move expansion of query macros in rustc_middle to rustc_middle::query) - rust-lang#111584 (Number lexing tweaks) - rust-lang#111587 (Custom MIR: Support `Rvalue::CopyForDeref`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit fc30207 into rust-lang:master May 15, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

8 participants