Render missing generics suggestion verbosely #106608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot added S-waiting-on-review 
| r? @estebank |
| @bors r+ rollup |
bors added S-waiting-on-bors JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 9, 2023
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 9, 2023
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
bors added S-waiting-on-author 
compiler-errors force-pushed the missing-generics-verbose branch from 21ff605 to 7c2dff0 Compare | Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
| Blessed clippy test failure @bors r=estebank |
bors added S-waiting-on-bors compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 9, 2023
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
| @bors r- |
bors added S-waiting-on-author 
compiler-errors force-pushed the missing-generics-verbose branch from 7c2dff0 to bf0623e Compare | @bors r=estebank |
bors added S-waiting-on-bors matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 13, 2023
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#106608 (Render missing generics suggestion verbosely) - rust-lang#106716 ([RFC 2397] Deny incorrect locations) - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`) - rust-lang#106782 (Ignore tests move in git blame) - rust-lang#106785 (Make blame spans better for impl wfcheck) - rust-lang#106791 (Fix ICE formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 27, 2023
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 27, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#106608 (Render missing generics suggestion verbosely) - rust-lang#106716 ([RFC 2397] Deny incorrect locations) - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`) - rust-lang#106782 (Ignore tests move in git blame) - rust-lang#106785 (Make blame spans better for impl wfcheck) - rust-lang#106791 (Fix ICE formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ":
, T" which render somewhat poorly inline.Also don't suggest
dynas a type parameter to add, even if technically that's valid in edition 2015.